feat(isMobilePhone): Added validation for Country: Eritrea #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1880 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2072 2072
Branches 472 472
=========================================
Hits 2072 2072
Continue to review full report at Codecov.
|
tux-tn
requested changes
Dec 17, 2021
| @@ -125,6 +125,7 @@ const phones = { | |||
| 'sv-SE': /^(\+?46|0)[\s\-]?7[\s\-]?[02369]([\s\-]?\d){7}$/, | |||
| 'tg-TJ': /^(\+?992)?[5][5]\d{7}$/, | |||
| 'th-TH': /^(\+66|66|0)\d{9}$/, | |||
| 'ti-ER': /^(\+?291) ?\d{10}$/, | |||
There was a problem hiding this comment.
Looks like there is some mobile carrier prefixes according to ITU. Can you change your regex in a way to validate only mobile phone numbers. Also, is the space in your regex necessary?
tux-tn
added
🎉 first-pr
🧹 needs-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the validation for country named Eritrea in isMobilePhone validator, updated the readme and also written the tests.
Checklist