Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing auto-generated files from git index #1590

Closed

Conversation

renanmontebelo
Copy link
Contributor

@renanmontebelo renanmontebelo commented Jan 31, 2021

Removing auto-generated files from git index.
These files are already in the .gitignore file but might have been accidently included in #1495.

This should decrease the risk of including stray files in future PRs.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #1590 (20cd5be) into master (1b85829) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1590   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          100       100           
  Lines         1796      1796           
=========================================
  Hits          1796      1796           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b85829...6fd13e1. Read the comment docs.

@ktorn
Copy link

ktorn commented Feb 1, 2021

Instead of submitting a new PR I believe you should amend your original PR commit as I doubt it will be merged that way.

@renanmontebelo
Copy link
Contributor Author

Actually it was indeed merged, and it was not a PR from me :-)

@ktorn
Copy link

ktorn commented Feb 3, 2021

@renanmontebelo indeed. Nevermind :)

@renanmontebelo
Copy link
Contributor Author

Closing as this will be taken care by #1553.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants