Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isEAN) - added support for EAN-14 along with test case, feat(isAlphanumeric)- added options(optional parameter) #1577

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

varsubham
Copy link
Contributor

@varsubham varsubham commented Jan 15, 2021

Fix Issue #1576
Fix Issue #1572

Checklist

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #1577 (ff175d8) into master (1b85829) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1577   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          100       100           
  Lines         1796      1807   +11     
=========================================
+ Hits          1796      1807   +11     
Impacted Files Coverage Δ
src/lib/isPassportNumber.js 100.00% <ø> (ø)
src/lib/isAlphanumeric.js 100.00% <100.00%> (ø)
src/lib/isDataURI.js 100.00% <100.00%> (ø)
src/lib/isEAN.js 100.00% <100.00%> (ø)
src/lib/isIdentityCard.js 100.00% <100.00%> (ø)
src/lib/isMACAddress.js 100.00% <100.00%> (ø)
src/lib/isStrongPassword.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b85829...a300bab. Read the comment docs.

@varsubham varsubham changed the title added support for EAN-14 along with test case feat(isEAN) - added support for EAN-14 along with test case, feat(isAlphanumeric)- added options(optional parameter) Jan 18, 2021
@varsubham
Copy link
Contributor Author

@profnandaa Hey can you please review the PR its one of my first PR 😄.
If there are any errors please let me know. 🙂

@renanmontebelo
Copy link
Contributor

I believe they are waiting for #1553 before reviewing any other PR.

@renanmontebelo
Copy link
Contributor

I believe the PR should only include files under src/, test/ and README.md; /validator.js and /validator.min.js are automatically generated by the build process (and by npm test) if I'm not mistaken.

@varsubham
Copy link
Contributor Author

@renanmontebelo I thought that we need to check if all the test cases are running (npm test) before submitting a PR 🤔

@renanmontebelo
Copy link
Contributor

These files are listed in .gitignore so I believe they shouldn't be added. Still, someone accidently added them that's why it's yielding as a modified file. See #1590 discussion.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congrats for your first contrib @varsubham . I deleted validator.js and validator.min.js to fix merge conflicts, apart from that LGTM 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants