-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isEAN) - added support for EAN-14 along with test case, feat(isAlphanumeric)- added options(optional parameter) #1577
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1577 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 100
Lines 1796 1807 +11
=========================================
+ Hits 1796 1807 +11
Continue to review full report at Codecov.
|
@profnandaa Hey can you please review the PR its one of my first PR 😄. |
I believe they are waiting for #1553 before reviewing any other PR. |
I believe the PR should only include files under |
@renanmontebelo I thought that we need to check if all the test cases are running ( |
These files are listed in .gitignore so I believe they shouldn't be added. Still, someone accidently added them that's why it's yielding as a modified file. See #1590 discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and congrats for your first contrib @varsubham . I deleted validator.js
and validator.min.js
to fix merge conflicts, apart from that LGTM 🎉
Fix Issue #1576
Fix Issue #1572
Checklist