-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid Russian passport number regex #1807
Comments
Thank you for reporting this issue @Chormon. Looks like the person that added the validation mixed between internal and international passport number.
PRs are welcome! |
So should it accept both or only international passport numbers? |
As far as I understand, domestic passport is more like ID card. |
can you assign this issue for me? |
Looks like only 9 digit passport numbers are valid. The 10 digit version is as Chromon said used like an ID Card.
@Tharunkumar001 sorry but @Theta-Dev asked first 😅 Feel free to pick another issue or check #1761 if you want to contribute as part of hacktoberfest |
Why is the regex actually seperated into 3 groups instead of simply |
No idea, you will probably want to change that too 😅 |
Hey, can you assign me this task? |
@tux-tn please close the issue as it is already been fixed |
Thank you but the PR has not been merged yet |
* fix: Russian passport number regex fixes #1807
* fix: Russian passport number regex fixes validatorjs#1807
* fix: Russian passport number regex fixes #1807
* fix: Russian passport number regex fixes #1807
International Russian passport contains 9 digits, not 10:
validator.js/src/lib/isPassportNumber.js
Line 53 in 13651ea
The text was updated successfully, but these errors were encountered: