Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu entries for Flow routes are not populated to dynamic menu #2825

Closed
Tracked by #6634
mshabarov opened this issue Oct 14, 2024 · 1 comment
Closed
Tracked by #6634

Menu entries for Flow routes are not populated to dynamic menu #2825

mshabarov opened this issue Oct 14, 2024 · 1 comment
Assignees
Labels
bug Something isn't working hilla Issues related to Hilla Released with Vaadin 24.5.0

Comments

@mshabarov
Copy link
Contributor

mshabarov commented Oct 14, 2024

Describe the bug

createMenuItems does not contain entries to Flow routes, which leads to absent menu items in Hilla's main layout, when it uses dynamic menu API.

Expected-behavior

A link for Flow route is available.

Reproduction

Download and start the project from https://github.com/vaadin/flow-hilla-hybrid-example/tree/v24.5.
Login as admin/admin.
Notice that the menu doesn't have a Flow menu item.

System Info

Vaadin 24.5.0.rc1.

@mshabarov mshabarov added bug Something isn't working hilla Issues related to Hilla labels Oct 14, 2024
@mshabarov mshabarov self-assigned this Oct 15, 2024
caalador pushed a commit to vaadin/flow that referenced this issue Oct 15, 2024
Adds a new util method that detects layout entries in file-routes.json.

Related-to vaadin/hilla#2825
mshabarov added a commit to vaadin/flow that referenced this issue Oct 15, 2024
Adds a new util method that detects layout entries in file-routes.json.

Related-to vaadin/hilla#2825
vaadin-bot pushed a commit to vaadin/flow that referenced this issue Oct 15, 2024
Adds a new util method that detects layout entries in file-routes.json.

Related-to vaadin/hilla#2825
mshabarov added a commit to vaadin/flow that referenced this issue Oct 15, 2024
Adds a new util method that detects layout entries in file-routes.json.

Related-to vaadin/hilla#2825
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hilla Issues related to Hilla Released with Vaadin 24.5.0
Projects
None yet
Development

No branches or pull requests

2 participants