Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add util method for detecting Hilla auto layout #20245

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Conversation

mshabarov
Copy link
Contributor

@mshabarov mshabarov commented Oct 14, 2024

Description

Adds a new util method that detects layout entries in file-routes.json.

Related-to vaadin/hilla#2825

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Copy link

github-actions bot commented Oct 14, 2024

Test Results

1 142 files  ± 0  1 142 suites  ±0   1h 24m 21s ⏱️ +20s
7 458 tests + 5  7 408 ✅ + 5  50 💤 ±0  0 ❌ ±0 
7 827 runs  +55  7 767 ✅ +55  60 💤 ±0  0 ❌ ±0 

Results for commit 6c9f777. ± Comparison against base commit b425bad.

♻️ This comment has been updated with latest results.

@mshabarov mshabarov marked this pull request as draft October 15, 2024 07:11
@mshabarov mshabarov marked this pull request as ready for review October 15, 2024 09:14
caalador
caalador previously approved these changes Oct 15, 2024
@mshabarov
Copy link
Contributor Author

It's MenuRegistryTest's new code that impacts should_not_initialize_UI_and_add_initialUidl_when_invalid_route somehow.
I'm looking into it.

@mshabarov
Copy link
Contributor Author

Or it's a file routes cache that is not cleaned.

@mshabarov
Copy link
Contributor Author

Added a cache cleanup for the failed test.
I think in real projects or end-to-end tests this problem shouldn't happen, because file routes are not going to be changed during app running in production.

However, unit tests may suffer.

Copy link

sonarcloud bot commented Oct 15, 2024

@caalador caalador merged commit b552d45 into 24.5 Oct 15, 2024
26 checks passed
@caalador caalador deleted the has-main-menu branch October 15, 2024 11:35
mshabarov added a commit that referenced this pull request Oct 15, 2024
Adds a new util method that detects layout entries in file-routes.json.

Related-to vaadin/hilla#2825
vaadin-bot pushed a commit that referenced this pull request Oct 15, 2024
Adds a new util method that detects layout entries in file-routes.json.

Related-to vaadin/hilla#2825
mshabarov added a commit that referenced this pull request Oct 15, 2024
Adds a new util method that detects layout entries in file-routes.json.

Related-to vaadin/hilla#2825
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants