Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Sep 20, 2025

The font size adjustment feature was not providing sufficient text size increases, particularly when users selected "特大" (Extra Large). Users reported that even the largest font setting was still too small for comfortable reading.

Problem

The original font size dimensions were too small for accessibility needs:

  • 小 (Small): 14dp
  • 中 (Medium): 16dp
  • 大 (Large): 18dp
  • 特大 (Extra Large): 20dp

Additionally, many UI components used fixed text styles that didn't scale with user preferences, creating inconsistent text sizing throughout the app.

Solution

Increased base font dimensions by +4dp across all sizes:

  • 小 (Small): 14dp → 18dp (+29% improvement)
  • 中 (Medium): 16dp → 20dp (+25% improvement)
  • 大 (Large): 18dp → 22dp (+22% improvement)
  • 特大 (Extra Large): 20dp → 24dp (+20% improvement)

Updated key text styles to use larger base sizes:

  • BodyText: Now uses mediumTextSize (20dp) instead of smallTextSize (18dp)
  • SubTitleText: Now uses largeTextSize (22dp) instead of mediumTextSize (20dp)
  • TopicTitle: Now uses largeTextSize (22dp) instead of mediumTextSize (20dp)

Impact

  • Better accessibility: All text sizes now meet improved readability standards
  • Significant improvement for 特大 setting: Users now get 24dp text instead of 20dp
  • Consistent experience: Both user-controlled and fixed text elements are larger
  • Broad coverage: Improvements affect topic titles, reply content, user names, settings text, notifications, and more
  • Maintains compatibility: Preserves existing responsive behavior while improving baseline sizes

The changes are minimal (7 lines across 2 files) but provide substantial readability improvements throughout the app.

Fixes #39.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • jitpack.io
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -XX:MaxMetaspaceSize=512m --add-exports=java.base/sun.nio.ch=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.reflect=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-exports=jdk.unsupported/sun.misc=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/gradle-daemon-main-8.13.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/agents/gradle-instrumentation-agent-8.13.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.13 (dns block)
  • maven.aliyun.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -XX:MaxMetaspaceSize=512m --add-exports=java.base/sun.nio.ch=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.reflect=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-exports=jdk.unsupported/sun.misc=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/gradle-daemon-main-8.13.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/agents/gradle-instrumentation-agent-8.13.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.13 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: graycreate <5203798+graycreate@users.noreply.github.com>
Copilot AI changed the title [WIP] 文字大小调整问题 Fix font size adjustment issues - increase text sizes for better accessibility Sep 20, 2025
Copilot AI requested a review from graycreate September 20, 2025 07:07
@graycreate graycreate marked this pull request as ready for review September 20, 2025 10:42
Copilot AI review requested due to automatic review settings September 20, 2025 10:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves text accessibility by increasing font sizes across all size categories and updating key text styles to use larger base sizes. The changes address user feedback that the "特大" (Extra Large) font setting was insufficient for comfortable reading.

  • Increased all font size dimensions by +4dp (20-29% improvement)
  • Updated three key text styles to use larger base sizes for better readability
  • Maintained existing responsive behavior while improving baseline accessibility

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
app/src/main/res/values/dimens.xml Increased all font size dimensions by +4dp across small, medium, large, and extra large sizes
app/src/main/res/values/styles.xml Updated SubTitleText, BodyText, and TopicTitle styles to use larger base font sizes

@graycreate graycreate closed this Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

文字大小调整问题

2 participants