Skip to content

Comments

[DFT] Fix MKLCPU DFT backend build issue#303

Merged
raphael-egan merged 3 commits intouxlfoundation:developfrom
FMarno:MKLCPU_fix
Apr 11, 2023
Merged

[DFT] Fix MKLCPU DFT backend build issue#303
raphael-egan merged 3 commits intouxlfoundation:developfrom
FMarno:MKLCPU_fix

Conversation

@FMarno
Copy link
Contributor

@FMarno FMarno commented Apr 3, 2023

Description

Fix a build issue introduced to the MKLCPU backend. This backend is not currently supported so the tests haven't been run.
This can be reproduced with the cmake setup

cmake -GNinja -Bbuild -S. -DCMAKE_CXX_COMPILER=/opt/intel/oneapi/compiler/2023.0.0/linux/bin/icpx -DCMAKE_C_COMPILER=/opt/intel/oneapi/compiler/2023.0.0/linux/bin/icx -DMKL_ROOT=/opt/intel/oneapi/mkl/2023.0.0

since ENABLE_MKLCPU_BACKEND is defaulted to ON and when no TARGET_DOMAIN is specified it will add dft automatically.

I've also updated the README because DFT was not listed as a supported domain.

Fixes #294

Checklist

All Submissions

  • Do all unit tests pass locally? Attach a log.
  • Have you formatted the code using clang-format?

Bug fixes

  • Have you added relevant regression tests? - NA
  • Have you included information on how to reproduce the issue (either in a
    GitHub issue or in this PR)?

@FMarno
Copy link
Contributor Author

FMarno commented Apr 3, 2023

@Rbiessy realised the issue with this solution is that we now have failing tests for the MLKCPU backend enabled. Here is a log of the test run: mklcpu_run.txt.
I decoded the return status of 3 with DftiErrorMessage and it said Intel MKL DFTI ERROR: Inconsistent configuration parameters.
I still personally believe #301 is the correct solution since the MKLCPU backend was never in a stable position to begin with.

@Rbiessy
Copy link
Contributor

Rbiessy commented Apr 3, 2023

#291 may fix this issue with the MKLCPU backend since it is not committing the descriptor when testing that we can get and set the values.
I agree that #301 is the safest approach until the CPU backend is properly enabled.

@FMarno
Copy link
Contributor Author

FMarno commented Apr 6, 2023

Test run - test_run.txt

Copy link
Contributor

@lhuot lhuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@raphael-egan raphael-egan merged commit a492e0a into uxlfoundation:develop Apr 11, 2023
@FMarno FMarno deleted the MKLCPU_fix branch April 11, 2023 16:22
normallytangent pushed a commit to normallytangent/oneMKL that referenced this pull request Aug 6, 2024
* fix mklcpu typo in descriptor

* update readme

* disabled examples and skip test for mklcpu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ctest fails at dft/EXAMPLE/RT/real_fwd_usm/cpu

5 participants