[DFT] Fix MKLCPU DFT backend build issue#303
Merged
raphael-egan merged 3 commits intouxlfoundation:developfrom Apr 11, 2023
Merged
[DFT] Fix MKLCPU DFT backend build issue#303raphael-egan merged 3 commits intouxlfoundation:developfrom
raphael-egan merged 3 commits intouxlfoundation:developfrom
Conversation
Contributor
Author
|
@Rbiessy realised the issue with this solution is that we now have failing tests for the MLKCPU backend enabled. Here is a log of the test run: mklcpu_run.txt. |
Contributor
Contributor
Author
|
Test run - test_run.txt |
dbollapr
approved these changes
Apr 11, 2023
raphael-egan
approved these changes
Apr 11, 2023
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
* fix mklcpu typo in descriptor * update readme * disabled examples and skip test for mklcpu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a build issue introduced to the MKLCPU backend. This backend is not currently supported so the tests haven't been run.
This can be reproduced with the cmake setup
since ENABLE_MKLCPU_BACKEND is defaulted to ON and when no TARGET_DOMAIN is specified it will add dft automatically.
I've also updated the README because DFT was not listed as a supported domain.
Fixes #294
Checklist
All Submissions
Bug fixes
GitHub issue or in this PR)?