Skip to content

Comments

[DFT] Split descriptor tests that do not need a device#291

Merged
Rbiessy merged 3 commits intouxlfoundation:developfrom
Rbiessy:dev/split_descriptor_tests
Apr 26, 2023
Merged

[DFT] Split descriptor tests that do not need a device#291
Rbiessy merged 3 commits intouxlfoundation:developfrom
Rbiessy:dev/split_descriptor_tests

Conversation

@Rbiessy
Copy link
Contributor

@Rbiessy Rbiessy commented Mar 8, 2023

Description

This builds on #259.

Some descriptor tests do not need a device as we do not need to commit
them. This follows from the discussion in #261 (comment).
The descriptor is now only committed to check that the commit status is
updated.

Checklist

All Submissions

  • Do all unit tests pass locally? Attach a log.
  • Have you formatted the code using clang-format?

New interfaces

  • Have you provided motivation for adding a new feature as part of RFC and
    it was accepted? # (RFC)
  • What version of oneAPI spec the interface is targeted?
  • Complete New features checklist

New features

  • Have you provided motivation for adding a new feature?
  • Have you added relevant tests?

Bug fixes

  • Have you added relevant regression tests?
  • Have you included information on how to reproduce the issue (either in a
    GitHub issue or in this PR)?

@Rbiessy
Copy link
Contributor Author

Rbiessy commented Mar 8, 2023

DFT descriptor test log: test_dft_descriptor_log.txt

Copy link
Contributor

@FMarno FMarno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hjabird hjabird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Some descriptor tests do not need a device as we do not need to commit
them.
The descriptor is now only committed to check that the commit status is
updated.
@Rbiessy
Copy link
Contributor Author

Rbiessy commented Apr 21, 2023

I have fixed the conflicts. Logs for the tests running with the CPU and GPU backends are attached: log_cpu.txt and log_gpu.txt.
FYI We have found unrelated issues when both backends are enabled and the tests using the compile time dispatch are run. CMake is currently linking with both backends so a test could be run on a gpu device with the CPU backend and fail. We are planning to fix this in a separate PR.

@Rbiessy Rbiessy merged commit 175dc61 into uxlfoundation:develop Apr 26, 2023
@Rbiessy Rbiessy deleted the dev/split_descriptor_tests branch April 26, 2023 11:33
normallytangent pushed a commit to normallytangent/oneMKL that referenced this pull request Aug 6, 2024
…#291)

[DFT] Split descriptor tests that do not need a device

Some descriptor tests do not need a device as we do not need to commit
them.
The descriptor is now only committed to check that the commit status is
updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants