[DFT] Split descriptor tests that do not need a device#291
Merged
Rbiessy merged 3 commits intouxlfoundation:developfrom Apr 26, 2023
Rbiessy:dev/split_descriptor_tests
Merged
[DFT] Split descriptor tests that do not need a device#291Rbiessy merged 3 commits intouxlfoundation:developfrom Rbiessy:dev/split_descriptor_tests
Rbiessy merged 3 commits intouxlfoundation:developfrom
Rbiessy:dev/split_descriptor_tests
Conversation
Contributor
Author
|
DFT descriptor test log: test_dft_descriptor_log.txt |
FMarno
reviewed
Mar 8, 2023
Some descriptor tests do not need a device as we do not need to commit them. The descriptor is now only committed to check that the commit status is updated.
4 tasks
lhuot
approved these changes
Apr 19, 2023
Contributor
Author
|
I have fixed the conflicts. Logs for the tests running with the CPU and GPU backends are attached: log_cpu.txt and log_gpu.txt. |
FMarno
approved these changes
Apr 21, 2023
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
…#291) [DFT] Split descriptor tests that do not need a device Some descriptor tests do not need a device as we do not need to commit them. The descriptor is now only committed to check that the commit status is updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This builds on #259.
Some descriptor tests do not need a device as we do not need to commit
them. This follows from the discussion in #261 (comment).
The descriptor is now only committed to check that the commit status is
updated.
Checklist
All Submissions
New interfaces
it was accepted? # (RFC)
New features
Bug fixes
GitHub issue or in this PR)?