Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel version update to 6.2 #2371

Merged
merged 25 commits into from
Jun 7, 2023
Merged

Bazel version update to 6.2 #2371

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
fd51108
New bazel version works
May 15, 2023
7b74856
Presumably working CI
May 15, 2023
2a8ada6
Another try
May 15, 2023
d26e1c2
GTest removal & minor fixes
May 15, 2023
f589b69
Fixed files
May 15, 2023
505ecbd
Minor
May 15, 2023
adc1a8a
Fixing wrong check in test
May 16, 2023
5b5c75b
Fixed test name
May 16, 2023
7667a73
Minor
May 16, 2023
f532f74
Update cpp/oneapi/dal/table/test/common.cpp
May 16, 2023
572d28f
Update cpp/oneapi/dal/table/test/common.cpp
May 16, 2023
32cfda9
Update cpp/oneapi/dal/table/test/column_accessor.cpp
May 16, 2023
c64ebd8
Update cpp/oneapi/dal/table/test/column_accessor.cpp
May 16, 2023
eb84d63
Update cpp/oneapi/dal/table/test/column_accessor.cpp
May 16, 2023
b69beee
Update cpp/oneapi/dal/table/test/column_accessor.cpp
May 16, 2023
9b0ae41
Update cpp/oneapi/dal/table/test/common.cpp
May 16, 2023
e0d66f2
Update .ci/pipeline/ci.yml
May 16, 2023
eba68f1
Update cpp/oneapi/dal/table/test/column_accessor.cpp
May 16, 2023
95abc5e
Update cpp/oneapi/dal/table/test/column_accessor.cpp
May 16, 2023
30ca8bc
Update cpp/oneapi/dal/table/test/column_accessor.cpp
May 16, 2023
e3b4c2f
Update cpp/oneapi/dal/table/test/column_accessor.cpp
May 16, 2023
a54a7b8
Update cpp/oneapi/dal/table/test/column_accessor.cpp
May 16, 2023
d92802e
Update cpp/oneapi/dal/table/test/column_accessor.cpp
May 16, 2023
04ff745
Update cpp/oneapi/dal/table/test/column_accessor.cpp
May 16, 2023
c0ed289
Minor
May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor
  • Loading branch information
Nikita Kulikov committed May 30, 2023
commit 505ecbd1f83ec26804b52da46d1aac1cbd1c382c
37 changes: 18 additions & 19 deletions cpp/oneapi/dal/table/test/column_accessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

namespace oneapi::dal {

TEST("column_accessor_test, can_get_first_column_from_homogen_table") {
TEST("column_accessor_test can_get_first_column_from_homogen_table") {
using oneapi::dal::detail::empty_delete;

float data[] = { 1.f, 2.f, //
Expand All @@ -40,7 +40,7 @@ TEST("column_accessor_test, can_get_first_column_from_homogen_table") {
}
}

TEST("column_accessor_test, can_get_second_column_from_homogen_table_with_conversion") {
TEST("column_accessor_test can_get_second_column_from_homogen_table_with_conversion") {
using oneapi::dal::detail::empty_delete;

float data[] = { 1.f, 2.f, 3.f, 4.f, 5.f, 6.f, 7.f, 8.f };
Expand All @@ -57,7 +57,7 @@ TEST("column_accessor_test, can_get_second_column_from_homogen_table_with_conver
}
}

TEST("column_accessor_test, can_get_first_column_from_homogen_table_with_subset_of_rows") {
TEST("column_accessor_test can_get_first_column_from_homogen_table_with_subset_of_rows") {
using oneapi::dal::detail::empty_delete;

float data[] = { 1.f, 2.f, 3.f, 4.f, 5.f, 6.f, 7.f, 8.f };
Expand All @@ -74,7 +74,7 @@ TEST("column_accessor_test, can_get_first_column_from_homogen_table_with_subset_
}
}

TEST("column_accessor_test, can_get_columns_from_homogen_table_builder") {
TEST("column_accessor_test can_get_columns_from_homogen_table_builder") {
detail::homogen_table_builder b;
b.reset(array<float>::zeros(3 * 2), 3, 2);
{
Expand Down Expand Up @@ -108,7 +108,7 @@ TEST("column_accessor_test, can_get_columns_from_homogen_table_builder") {
}
}

TEST("column_accessor_test, can_get_column_values_from_column_major_homogen_table") {
TEST("column_accessor_test can_get_column_values_from_column_major_homogen_table") {
float data[] = { 0.f, 1.f, 2.f, 3.f, 4.f, 5.f, 6.f, 7.f, 8.f, 9.f, 10.f, 11.f };

auto t = homogen_table::wrap(data, 4, 3, data_layout::column_major);
Expand All @@ -122,8 +122,7 @@ TEST("column_accessor_test, can_get_column_values_from_column_major_homogen_tabl
REQUIRE(col[1] == 6.f);
}

TEST(
"column_accessor_test, can_get_column_values_from_column_major_homogen_table_with_conversion") {
TEST("column_accessor_test can_get_column_values_from_column_major_homogen_table_with_conversion") {
float data[] = { 0.f, 1.f, 2.f, 3.f, 4.f, 5.f, 6.f, 7.f, 8.f, 9.f, 10.f, 11.f };

auto t = homogen_table::wrap(data, 4, 3, data_layout::column_major);
Expand All @@ -136,7 +135,7 @@ TEST(
REQUIRE(col[1] == 6);
}

TEST("column_accessor_bad_arg_test, invalid_range") {
TEST("column_accessor_bad_arg_test invalid_range") {
detail::homogen_table_builder b;
b.reset(array<float>::zeros(3 * 2), 3, 2);
column_accessor<float> acc{ b };
Expand All @@ -151,7 +150,7 @@ TEST("column_accessor_bad_arg_test, invalid_range") {
}

#ifdef ONEDAL_DATA_PARALLEL
TEST("column_accessor_dpc_test, can_get_first_column_from_homogen_table") {
TEST("column_accessor_dpc_test can_get_first_column_from_homogen_table") {
sycl::queue q;
constexpr std::int64_t data_size = 8;
auto data = sycl::malloc_shared<float>(data_size, q);
Expand All @@ -175,7 +174,7 @@ TEST("column_accessor_dpc_test, can_get_first_column_from_homogen_table") {
}
}

TEST("column_accessor_dpc_test, can_get_second_column_from_homogen_table_with_conversion") {
TEST("column_accessor_dpc_test can_get_second_column_from_homogen_table_with_conversion") {
sycl::queue q;
constexpr std::int64_t data_size = 8;
auto data = sycl::malloc_shared<float>(data_size, q);
Expand All @@ -199,7 +198,7 @@ TEST("column_accessor_dpc_test, can_get_second_column_from_homogen_table_with_co
}
}

TEST("column_accessor_dpc_test, can_get_first_column_from_homogen_table_with_subset_of_rows") {
TEST("column_accessor_dpc_test can_get_first_column_from_homogen_table_with_subset_of_rows") {
sycl::queue q;
constexpr std::int64_t data_size = 8;
auto data = sycl::malloc_shared<float>(data_size, q);
Expand All @@ -223,7 +222,7 @@ TEST("column_accessor_dpc_test, can_get_first_column_from_homogen_table_with_sub
}
}

TEST("column_accessor_dpc_test, can_get_columns_from_homogen_table_builder") {
TEST("column_accessor_dpc_test can_get_columns_from_homogen_table_builder") {
sycl::queue q;

detail::homogen_table_builder b;
Expand Down Expand Up @@ -265,7 +264,7 @@ TEST("column_accessor_dpc_test, can_get_columns_from_homogen_table_builder") {
}
}

TEST("column_accessor_dpc_test, can_get_column_values_from_column_major_homogen_table") {
TEST("column_accessor_dpc_test can_get_column_values_from_column_major_homogen_table") {
sycl::queue q;
constexpr std::int64_t row_count = 4;
constexpr std::int64_t column_count = 3;
Expand Down Expand Up @@ -293,8 +292,8 @@ TEST("column_accessor_dpc_test, can_get_column_values_from_column_major_homogen_
sycl::free(data, q);
}

TEST("column_accessor_dpc_test,
can_get_column_values_from_column_major_homogen_table_with_conversion") {
TEST(
"column_accessor_dpc_test can_get_column_values_from_column_major_homogen_table_with_conversion") {
sycl::queue q;
constexpr std::int64_t row_count = 4;
constexpr std::int64_t column_count = 3;
Expand All @@ -303,9 +302,9 @@ TEST("column_accessor_dpc_test,
auto data = sycl::malloc_shared<float>(data_size, q);

auto event = q.submit([&](sycl::handler& cgh) {
cgh.parallel_for(sycl::range<1>(data_size), [=](sycl::id<1> idx) {
data[idx[0]] = idx[0];
});
cgh.parallel_for(sycl::range<1>(data_size), [=](sycl::id<1> idx) {
data[idx[0]] = idx[0];
});
});

auto t =
Expand All @@ -321,7 +320,7 @@ TEST("column_accessor_dpc_test,
sycl::free(data, q);
}

TEST("column_accessor_bad_arg_dpc_test, invalid_range") {
TEST("column_accessor_bad_arg_dpc_test invalid_range") {
sycl::queue q;

detail::homogen_table_builder b;
Expand Down
6 changes: 3 additions & 3 deletions cpp/oneapi/dal/table/test/common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@
using namespace oneapi::dal;
using namespace oneapi;

TEST("table_test, can_construct_empty_table") {
TEST("table_test can_construct_empty_table") {
table t;

REQUIRE(!t.has_data());
REQUIRE(t.get_row_count() == 0);
REQUIRE(t.get_column_count() == 0);
}

TEST("simple_metadata_bad_arg_tests, get_feature_type") {
TEST("simple_metadata_bad_arg_tests get_feature_type") {
const std::int64_t n_features = 5;
auto dtypes = array<data_type>::full(n_features, data_type::int32);
auto ftypes = array<feature_type>::full(n_features, feature_type::nominal);
Expand All @@ -40,7 +40,7 @@ TEST("simple_metadata_bad_arg_tests, get_feature_type") {
REQUIRE_NOTHROW(md.get_feature_type(0));
}

TEST("simple_metadata_bad_arg_tests, get_data_type") {
TEST("simple_metadata_bad_arg_tests get_data_type") {
const std::int64_t n_features = 5;
auto dtypes = array<data_type>::full(n_features, data_type::int32);
auto ftypes = array<feature_type>::full(n_features, feature_type::nominal);
Expand Down