Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel version update to 6.2 #2371

Merged
merged 25 commits into from
Jun 7, 2023
Merged

Bazel version update to 6.2 #2371

merged 25 commits into from
Jun 7, 2023

Conversation

KulikovNikita
Copy link
Contributor

No description provided.

@KulikovNikita KulikovNikita added infra testing dependencies Pull requests that update a dependency file labels May 15, 2023
@napetrov
Copy link
Contributor

to simplify things - this would require switch to bazilesk in publicCI as well as in internal CI

@KulikovNikita KulikovNikita requested a review from aepanchi May 15, 2023 16:26
@KulikovNikita
Copy link
Contributor Author

@napetrov @maria-Petrova - please check third-party-programs.txt

@KulikovNikita
Copy link
Contributor Author

/intelci: run

@KulikovNikita KulikovNikita marked this pull request as ready for review May 16, 2023 06:43
@KulikovNikita
Copy link
Contributor Author

/intelci: run

aepanchi
aepanchi reviewed May 16, 2023
View reviewed changes
cpp/oneapi/dal/table/test/column_accessor.cpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/table/test/column_accessor.cpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/table/test/column_accessor.cpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/table/test/column_accessor.cpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/table/test/column_accessor.cpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/table/test/column_accessor.cpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/table/test/column_accessor.cpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/table/test/common.cpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/table/test/common.cpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/table/test/common.cpp Outdated Show resolved Hide resolved
@KulikovNikita
Copy link
Contributor Author

/intelci: run

Alexsandruss
Alexsandruss reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@Alexsandruss Alexsandruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel testing in private CI failed so fix or justification for it is required.

cpp/oneapi/dal/algo/louvain/test/louvain_test.cpp Show resolved Hide resolved
@homksei
Copy link
Contributor

homksei commented May 25, 2023

Failures with the new bazel version in private CI: Intel-CI-edfa3b31-7fff-f1d4-8a0d-a4bf010d0e2e

@KulikovNikita
Copy link
Contributor Author

Updated: https://intel-ci.intel.com/edfad31c-8f9a-f142-bc12-a4bf010d0e2e

@napetrov napetrov changed the title New Bazel version Bazel version update to 6.2 May 29, 2023
KulikovNikita and others added 15 commits May 30, 2023 07:41
@aepanchi
Update cpp/oneapi/dal/table/test/common.cpp
572d28f 
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
@aepanchi
Update cpp/oneapi/dal/table/test/column_accessor.cpp
32cfda9 
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
@aepanchi
Update cpp/oneapi/dal/table/test/column_accessor.cpp
c64ebd8 
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
@aepanchi
Update cpp/oneapi/dal/table/test/column_accessor.cpp
eb84d63 
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
@aepanchi
Update cpp/oneapi/dal/table/test/column_accessor.cpp
b69beee 
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
@aepanchi
Update cpp/oneapi/dal/table/test/common.cpp
9b0ae41 
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
@aepanchi
Update .ci/pipeline/ci.yml
e0d66f2 
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
@aepanchi
Update cpp/oneapi/dal/table/test/column_accessor.cpp
eba68f1 
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
@aepanchi
Update cpp/oneapi/dal/table/test/column_accessor.cpp
95abc5e 
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
@aepanchi
Update cpp/oneapi/dal/table/test/column_accessor.cpp
30ca8bc 
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
@aepanchi
Update cpp/oneapi/dal/table/test/column_accessor.cpp
e3b4c2f 
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
@aepanchi
Update cpp/oneapi/dal/table/test/column_accessor.cpp
a54a7b8 
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
@aepanchi
Update cpp/oneapi/dal/table/test/column_accessor.cpp
d92802e 
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
@aepanchi
Update cpp/oneapi/dal/table/test/column_accessor.cpp
04ff745 
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
Minor
c0ed289
@KulikovNikita KulikovNikita force-pushed the dev/new-bazel-adopt branch from 59f824f to c0ed289 Compare May 30, 2023 14:42
@napetrov
Copy link
Contributor

napetrov commented Jun 6, 2023

Let's wait for branch creation so this would go to master only - @homksei @maria-Petrova

@napetrov napetrov merged commit 23786e6 into uxlfoundation:master Jun 7, 2023
@napetrov napetrov mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aepanchi aepanchi aepanchi left review comments

@homksei homksei homksei approved these changes

@Alexsandruss Alexsandruss Alexsandruss approved these changes

@maria-Petrova maria-Petrova Awaiting requested review from maria-Petrova

@napetrov napetrov Awaiting requested review from napetrov

@samir-nasibli samir-nasibli Awaiting requested review from samir-nasibli

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file infra testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KulikovNikita @napetrov @homksei @Alexsandruss @aepanchi