Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain the membership process when no UW ID is passed in .member #504

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

KuroganeToyama
Copy link
Contributor

Summary of Changes

  • Made the uwid field optional instead of required
  • An embed with membership info will show up if no uwid is passed in

Resolved Requests

Notes

I'd say my membership explanation isn't exactly the most appealing one, so I'm open to any suggestions to make it more appealing.

Copy link
Contributor

@probro27 probro27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KuroganeToyama The code itself is good. Only change I want is to just edit the message a bit, and take care of the linting issue which can be fixed by putting the entire EmbedBuilder in a single line.

src/commandDetails/miscellaneous/member.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@probro27 probro27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KuroganeToyama LGTM! Thank you for resolving all of the issues. Whenever you are ready you can squash and merge!

@KuroganeToyama KuroganeToyama merged commit 32e8541 into main Jan 19, 2024
2 checks passed
@KuroganeToyama KuroganeToyama deleted the issue-#498 branch January 19, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants