Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify .member #499

Closed
wants to merge 5 commits into from
Closed

Modify .member #499

wants to merge 5 commits into from

Conversation

siumairice
Copy link
Collaborator

Summary of Changes

Modified .member to explain the process of becoming a member instead

Related Issues

Closes #498

Steps to Reproduce

Try .member

@Fan-Yang-284
Copy link
Contributor

Looks great! Just a couple things:

  • could you separate the changes for issues 498 and 477
  • for the new message maybe just skip the first line and start with the 'Being a CSC member...'
  • since it no longer represents invalid usage, maybe set the embed colour to blue (or another colour you think would be suitable)

@mcpenguin
Copy link
Collaborator

Seems there are linting errors with this right now.

Copy link
Contributor

@probro27 probro27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siumairice LGTM! Thanks for completing this
Squash and merge it whenever you are ready!

@probro27 probro27 self-requested a review November 5, 2023 04:25
Copy link
Contributor

@Fan-Yang-284 Fan-Yang-284 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really sorry - I thought the new text changes were only relevant to when the user doesn't pass in an ID. Currently both the cases of

  1. no ID being passed in
  2. ID being passed in, not a member

use the NOT_MEMBER_DESCRIPTION message. The first case is fine as is, but in the second case we should still explicitly say that they aren't a CSC member as before, with maybe something like this.

return new EmbedBuilder().setColor('Red').setTitle(title).setDescription(`You're not a CSC member! ${getEmojiByName('codey_sad')}
  
${NOT_MEMBER_DESCRIPTION}`);

@probro27
Copy link
Contributor

Moved to #504
Closing this PR!

@probro27 probro27 closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify .member to explain how to become a member
4 participants