-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify .member #499
Modify .member #499
Conversation
Looks great! Just a couple things:
|
Seems there are linting errors with this right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siumairice LGTM! Thanks for completing this
Squash and merge it whenever you are ready!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really sorry - I thought the new text changes were only relevant to when the user doesn't pass in an ID. Currently both the cases of
- no ID being passed in
- ID being passed in, not a member
use the NOT_MEMBER_DESCRIPTION
message. The first case is fine as is, but in the second case we should still explicitly say that they aren't a CSC member as before, with maybe something like this.
return new EmbedBuilder().setColor('Red').setTitle(title).setDescription(`You're not a CSC member! ${getEmojiByName('codey_sad')}
${NOT_MEMBER_DESCRIPTION}`);
Moved to #504 |
Summary of Changes
Modified .member to explain the process of becoming a member instead
Related Issues
Closes #498
Steps to Reproduce
Try
.member