sync
: cleanup and implement fsync
if files are given
#5850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
PathBuf
now, allowing invalid UTF-8fsync
now if files are given but neither--data
or--file-system
is passed.unsafe
, because they aren't :)--data
and--file-system
are hidden when they are not supported--data
and--file-system
trigger an error when they are used, but not supportedcfg
gates.I can't be bothered with also fixing Windows right now :)
I tried to use
nix
, but it was sadly missing some Android stuff, which I've made a PR for: nix-rust/nix#2296.