Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: cleanup and implement fsync if files are given #5850

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tertsdiepraam
Copy link
Member

@tertsdiepraam tertsdiepraam commented Jan 17, 2024

Changes:

  • The files are PathBuf now, allowing invalid UTF-8
  • We've got fsync now if files are given but neither --data or --file-system is passed.
  • We no longer check the paths up front, but while opening the paths.
  • Our functions are no longer marked unsafe, because they aren't :)
  • --data and --file-system are hidden when they are not supported
  • --data and --file-system trigger an error when they are used, but not supported
  • Some functions were (I think) available on more platforms that what we were using, so I tried to remove from cfg gates.

I can't be bothered with also fixing Windows right now :)

I tried to use nix, but it was sadly missing some Android stuff, which I've made a PR for: nix-rust/nix#2296.

@tertsdiepraam tertsdiepraam changed the title sync: cleanup and implement fsync if files are given sync: cleanup and implement fsync if files are given Jan 17, 2024
@tertsdiepraam
Copy link
Member Author

Meh, I'll fix Mac soon

Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/sync. tests/misc/sync is passing on 'main'. Maybe you have to rebase?

@sylvestre
Copy link
Contributor

@tertsdiepraam ping ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants