enable unistd::{sync, syncfs} on Android #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the contribution, changes look good, though a changelog is needed: // changelog/2296.added.md
Enable unistd::{sync, syncfs} for Android |
tertsdiepraam
force-pushed
the
sync-platforms
branch
from
c91798d
to
0dfa0ae
Compare
|
Ahhh that's how that works. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
unistd::{sync, syncfs}were not implemented on Android, even though they are available inlibc:I'm not sure if it makes a difference, but especially
syncwas added fairly recently (9 months ago in rust-lang/libc@0ba1fc4).Checklist:
CONTRIBUTING.md