RID is no longer a native coretype #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedNaru
requested review from
chippmann and
piiertho
and removed request for
chippmann
CedNaru
force-pushed
the
improvement/kotlin-rid
branch
from
ea4992f to
cbc9d3f
Compare
chippmann
previously approved these changes
Sep 12, 2024
CedNaru
force-pushed
the
fix/signal_buffer
branch
2 times, most recently
from
770c971 to
0f95703
Compare
CedNaru
force-pushed
the
improvement/kotlin-rid
branch
from
a2b586b to
1c21fac
Compare
piiertho
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a pointer to the native RID for it but it's really just a simple wrapper around an uint64
I renamed
coreTypesReimplementedInKotlintolocalCopyCoreTypebecause we only use it to generate the local copy helpers in the api gen and RID is not in that list. RID doesn't need those helpers because its only field can't be mutated anyway. Adding helpers for it would only bloat the code for nothing.If you wonder why it wasn't reimplemented directly in Kotlin before. It's simply because back in Godot 3.x, RID also had a pointer to its owner. This is no longer the case, so we can get RID of the bridge.