Fix API generation

Author: CedNaru

kt/api-generator/src/main/kotlin/godot/codegen/extensions/TypedExtensions.kt

@@ -51,7 +51,7 @@ const val bitfieldPrefix = "bitfield::"
 
 fun TypedTrait.isCoreType() = isTypedArray() || GodotTypes.coreTypes.find { s -> s == this.type } != null
 fun TypedTrait.isPrimitive() = GodotTypes.primitives.find { s -> s == this.type } != null
-fun TypedTrait.isCoreTypeReimplementedInKotlin() = GodotTypes.coreTypesReimplementedInKotlin.find { s ->
+fun TypedTrait.isLocalCopyCoreTypes() = GodotTypes.localCopyCoreTypes.find { s ->
     s == this.type
 } != null
 fun TypedTrait.isEnum() = type?.startsWith(enumPrefix) ?: false

kt/api-generator/src/main/kotlin/godot/codegen/services/impl/GenerationService.kt

@@ -25,8 +25,8 @@ import godot.codegen.extensions.applyJvmNameIfNecessary
 import godot.codegen.extensions.getDefaultValueKotlinString
 import godot.codegen.extensions.getTypeClassName
 import godot.codegen.extensions.isBitField
-import godot.codegen.extensions.isCoreTypeReimplementedInKotlin
 import godot.codegen.extensions.isEnum
+import godot.codegen.extensions.isLocalCopyCoreTypes
 import godot.codegen.extensions.jvmVariantTypeValue
 import godot.codegen.models.custom.AdditionalImport
 import godot.codegen.models.enriched.EnrichedClass
@@ -167,7 +167,7 @@ class GenerationService(
         for (property in enrichedClass.properties) {
             val propertySpec = generateProperty(enrichedClass, property) ?: continue
             classTypeBuilder.addProperty(propertySpec)
-            if (property.hasValidSetterInClass && property.isCoreTypeReimplementedInKotlin()) {
+            if (property.hasValidSetterInClass && property.isLocalCopyCoreTypes()) {
                 classTypeBuilder.addFunction(generateCoreTypeHelper(enrichedClass, property))
             }
         }
@@ -505,7 +505,7 @@ class GenerationService(
             )
         }
 
-        if (property.isCoreTypeReimplementedInKotlin()) {
+        if (property.isLocalCopyCoreTypes()) {
             propertySpecBuilder.addAnnotation(CORE_TYPE_LOCAL_COPY)
         }
 
@@ -519,7 +519,6 @@ class GenerationService(
         val parameterName = property.name
         val propertyFunSpec = FunSpec.builder("${parameterName}Mutate").addModifiers(KModifier.FINAL)
 
-
         return propertyFunSpec
             .addParameter(
                 ParameterSpec.builder(

kt/godot-library/src/main/kotlin/godot/core/bridge/RID.kt

@@ -2,28 +2,24 @@
 
 package godot.core
 
-@Suppress("MemberVisibilityCanBePrivate")
-class RID : Comparable<RID> {
-
+class RID(
     /**
      * Returns the ID of the referenced low-level resource.
      */
     val id: Long
+) : Comparable<RID> {
+
 
     //CONSTRUCTOR
     /**
      * Constructs an empty RID with the invalid ID 0.
      */
-    constructor(id: Long) {
-        this.id = id
-    }
+    constructor(): this(0L)
 
     /**
      * Constructs a RID as a copy of the given RID.
      */
-    constructor(from: RID) {
-        this.id = from.id
-    }
+    constructor(from: RID): this(from.id)
 
     //API
     /**

kt/tools-common/src/main/kotlin/godot/tools/common/constants/Classes.kt

@@ -161,7 +161,8 @@ object GodotTypes {
         variant
     )
 
-    val coreTypesReimplementedInKotlin = listOf(
+    // We don't include RID because this core type can't be modified anyway and is a simple wrapper around Long.
+    val localCopyCoreTypes = listOf(
         aabb,
         basis,
         color,
@@ -177,7 +178,7 @@ object GodotTypes {
         vector3i,
         vector4,
         vector4i,
-        projection
+        projection,
     )
 
     val primitives = listOf(