Swap DriverManager for DataSource #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianhj
changed the title
|
Seems to be an issue with how Sonar is set-up (i.e. default URL of http://localhost:9000). How has this worked before as the other PR from January seems to push OK to sonarcloud.io with the default |
|
Hi @adrianhj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #23.
Swaps the
testgoal from using the DriverManager abstraction to a directly created DataSource to combat classloader issues when used in conjunction with other Maven plugins loading theoracle.jdbc.driver.OracleDriversuch as the Liquibase Maven Plugin.No option to set reviewers so @jgebal @pesse please.