Skip to content

Commit 6121870

Browse files
authored
Merge pull request #44 from adrianhj/bugfix/swap-drivermanager-for-datasource
Swap DriverManager for DataSource
2 parents bd9f725 + 8f4bd62 commit 6121870

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
<groupId>org.utplsql</groupId>
77
<artifactId>utplsql-maven-plugin</artifactId>
8-
<version>3.1.2-SNAPSHOT</version>
8+
<version>3.1.3-SNAPSHOT</version>
99
<packaging>maven-plugin</packaging>
1010

1111
<name>utPLSQL Maven Plugin</name>

src/main/java/org/utplsql/maven/plugin/UtPLSQLMojo.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,10 @@
22

33
import java.io.File;
44
import java.sql.Connection;
5-
import java.sql.DriverManager;
65
import java.sql.SQLException;
76
import java.util.ArrayList;
87
import java.util.List;
9-
8+
import oracle.jdbc.pool.OracleDataSource;
109
import org.apache.commons.lang3.StringUtils;
1110
import org.apache.maven.model.Resource;
1211
import org.apache.maven.plugin.AbstractMojo;
@@ -135,8 +134,11 @@ public void execute() throws MojoExecutionException {
135134
try {
136135
FileMapperOptions sourceMappingOptions = buildSourcesOptions();
137136
FileMapperOptions testMappingOptions = buildTestsOptions();
138-
139-
connection = DriverManager.getConnection(url, user, password);
137+
OracleDataSource ds = new OracleDataSource();
138+
ds.setURL(url);
139+
ds.setUser(user);
140+
ds.setPassword(password);
141+
connection = ds.getConnection();
140142

141143
Version utlVersion = DBHelper.getDatabaseFrameworkVersion(connection);
142144
getLog().info("utPLSQL Version = " + utlVersion);
@@ -173,6 +175,7 @@ public void execute() throws MojoExecutionException {
173175
try {
174176
if (null != connection) {
175177
reporterWriter.writeReporters(connection);
178+
connection.close();
176179
}
177180
} catch (Exception e) {
178181
getLog().error(e.getMessage(), e);

0 commit comments

Comments
 (0)