Feature/version check #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding orai18n to the dependencies
not sufficient though, we want to have a more specific check with fallback-mechanisms for some features
…PLSQL-java-api into feature/version_check
Also added some tests for getting Framework version and fixed error in getting it
As discussed in slack channel the goal is to have the most actual API version be compatible with the major version of the framework. API of a higher version should always be downwards compatible inside the same major version.
had to restructure current code a bit to support different implementations of TestRunner calls
API should now be able to work for Framework-version 3.0.0 - 3.0.3
…error Close reporters if any unexpected errors occurred while running tests
…into feature/version_check
If check is skipped, the API expects the latest framework version to be present
viniciusam
reviewed
Nov 9, 2017
| * | ||
| * @return | ||
| */ | ||
| public String getVersionString() |
There was a problem hiding this comment.
Why not override toString?
If it's valid, couldn't you just return the origString?
There was a problem hiding this comment.
Agreed with the toString() method.
But I wouldn't return the origString because the class does some normalization, too, e.g. "v3.0.3" will be normalized to "3.0.3" or "version3.0.3" will also be normalized to "3.0.3". With that we are a bit more resilient against little changes.
There was a problem hiding this comment.
Actually it might be even better to have the origString as toString-Method and getVersionString renamed to getNormalizedString
- TestRunnerStatement-Implementations are now hidden from public - DatabaseNotCompatibleException now uses Version-objects instead of strings - Version now contains a getNormalizedVersion()-method and it's toString()-method returns the original version string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included Version-Check with database framework.
If Java-API is not compatible, TestRunner throws a DatabaseNotComptabileException.
Also included a simple Compability solution so API should be usable for 3.0.1, 3.0.2 and 3.0.3