Skip to content

Adding orai18n to the dependencies #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2017
Merged

Adding orai18n to the dependencies #24

merged 1 commit into from
Oct 29, 2017

Conversation

viniciusam
Copy link
Member

Fix client issue:
utPLSQL/utPLSQL-cli#39

@viniciusam viniciusam merged commit f930370 into develop Oct 29, 2017
@viniciusam viniciusam deleted the bugfix/orai18n branch October 29, 2017 10:59
@jgebal
Copy link
Member

jgebal commented Oct 30, 2017

Looks like we were too fast with this step.
Need to be careful not to violate Oracle License agreement.
Instead of adding the binaries to the product, we probably need to have those dependencies listed as requirements in documentation?
I'm no expert on licensing matters, so you either need to do research on that or find someone who knows :)

@pesse
Copy link
Member

pesse commented Nov 4, 2017

I read a bit about the Oracle licensing. For the moment I think it would be safest if we don't provide ojdbc and orai18n binaries with the cli but request the users to download them on their own.

I know this is terrible from usability perspective, but if you provide Oracle binaries you have to enforce your own endusers to accept the Oracle Binary licence - which we don't and can't.

I think we have to stay the safe way or write an installer which enforces the user to download the jars with their own oracle account during installation process...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants