Skip to content

read fmf metadata for selected cases#160

Merged
TomasTomecek merged 3 commits intouser-cont:masterfrom
jscotka:fmf_data_split
Jul 25, 2018
Merged

read fmf metadata for selected cases#160
TomasTomecek merged 3 commits intouser-cont:masterfrom
jscotka:fmf_data_split

Conversation

@jscotka
Copy link
Collaborator

@jscotka jscotka commented Jul 17, 2018

ability to read metadata for tests from FMF files
previous PR already incorporated:

Features:

  • Split out testmedata from python code to separated files
  • Able to inherit metadata (FMF Tree inheritance) metadata coluld be simplified (for example there could be some main reference_url, what will be generic and more test could link to it, it it makes sense, or for example set some tags, or target type)
  • There are examples how to convert metadata from internal python classes to FMF format.

all metadata have to be converted: #156

@user-cont user-cont deleted a comment Jul 17, 2018
@user-cont user-cont deleted a comment Jul 17, 2018
@user-cont user-cont deleted a comment Jul 17, 2018
@user-cont user-cont deleted a comment Jul 17, 2018
@user-cont user-cont deleted a comment Jul 17, 2018
@user-cont user-cont deleted a comment Jul 17, 2018
@user-cont user-cont deleted a comment Jul 17, 2018
@user-cont user-cont deleted a comment Jul 17, 2018
@user-cont user-cont deleted a comment Jul 17, 2018
@user-cont user-cont deleted a comment Jul 17, 2018
@jscotka jscotka mentioned this pull request Jul 17, 2018
4 tasks
@jscotka jscotka force-pushed the fmf_data_split branch 3 times, most recently from b4080d4 to 018572f Compare July 18, 2018 10:52
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 18, 2018
@user-cont user-cont deleted a comment Jul 23, 2018
@user-cont user-cont deleted a comment Jul 23, 2018
@user-cont user-cont deleted a comment Jul 23, 2018
@user-cont user-cont deleted a comment Jul 23, 2018
@user-cont user-cont deleted a comment Jul 23, 2018
@user-cont user-cont deleted a comment Jul 23, 2018
@user-cont user-cont deleted a comment Jul 23, 2018
@user-cont user-cont deleted a comment Jul 23, 2018
@user-cont user-cont deleted a comment Jul 23, 2018
logger = logging.getLogger(__name__)


def receive_fmf_metadata(name, path, object_list=False):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish this function was integrated here: https://github.com/user-cont/colin/blob/master/colin/core/loader.py

so that you don't have to pass the path in such a hacky way (from cli via changing attribute on a class)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fixed, metadata loaded in loader.py

@user-cont user-cont deleted a comment Jul 24, 2018
@user-cont user-cont deleted a comment Jul 24, 2018
@user-cont user-cont deleted a comment Jul 24, 2018
@user-cont user-cont deleted a comment Jul 24, 2018
@user-cont user-cont deleted a comment Jul 24, 2018
@user-cont user-cont deleted a comment Jul 24, 2018
@user-cont user-cont deleted a comment Jul 24, 2018
example of ingeritance for tags

quick fix of unit test cli, because it should not be tag seq dependent
@user-cont user-cont deleted a comment Jul 24, 2018
@user-cont user-cont deleted a comment Jul 24, 2018
@user-cont user-cont deleted a comment Jul 24, 2018
@user-cont user-cont deleted a comment Jul 24, 2018
@user-cont user-cont deleted a comment Jul 24, 2018
@user-cont user-cont deleted a comment Jul 24, 2018
@user-cont user-cont deleted a comment Jul 24, 2018
Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomasTomecek TomasTomecek merged commit bd8a499 into user-cont:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants