FMF metadata support to colin by jscotka · Pull Request #141 · user-cont/colin

jscotka · 2018-05-31T14:11:12Z

FMF Metadata works well

FMF metadata support in colin. There are two different parts

test objects can read FMF metadata from files on demand
scheduler
- dynamic nosetests generator
- FMF rulesets support
- filtering abilities

TODOs:

research how to ideally solve two __init__() or how to check that all variables are set
find way how to name tests
transform all __init__ s to FMF compatible way
find way how transform rulesets to FMF testsets
remove all duplicated stuff from colin what is already implemented by FMF** (next PRs)
- remove duplicated code: Remove duplicated code what is in FMF and colin implementatiopn #155
- add FMF metadata for all testcases: add FMF metadata to all existing testcases #156

Colin output:

$ python -m colin.cli.colin list-checks

maintainer_label
   -> Label 'maintainer' has to be specified.
   -> The name and email of the maintainer (usually the submitter).
   -> https://fedoraproject.org/wiki/Container:Guidelines#LABELS
   -> maintainer, label, required

from_tag_not_latest
   -> In FROM, tag has to be specified and not 'latest'.
   -> Using the 'latest' tag may cause unpredictable builds.It is recommended that a specific tag is used in the FROM.
   -> https://fedoraproject.org/wiki/Container:Guidelines#FROM
   -> from, dockerfile, baseimage, latest, required

maintainer_deprecated
   -> Dockerfile instruction `MAINTAINER` is deprecated.
   -> Replace with label 'maintainer'.
   -> https://docs.docker.com/engine/reference/builder/#maintainer-deprecated
   -> maintainer, dockerfile, deprecated, required

python -m colin.cli.colin check tests/data/Dockerfile

PASS:Label 'maintainer' has to be specified.
PASS:In FROM, tag has to be specified and not 'latest'.
PASS:Dockerfile instruction `MAINTAINER` is deprecated.

PASS:3

FMF output

fmf show --path colin/checks

/best_practices/cmd_or_entrypoint
class: CmdOrEntrypointCheck
description: An ENTRYPOINT allows you to configure a container that will run as an executable. The main purpose of a CMD is to provide defaults for an executing container.
message: Cmd or Entrypoint has to be specified
reference_url: https://fedoraproject.org/wiki/Container:Guidelines#CMD.2FENTRYPOINT_2
tags: cmd and entrypoint
test: best_practices.py

/best_practices/help_file_or_readme
all_must_be_present: False
class: HelpFileOrReadmeCheck
description: Just like traditional packages, containers need some 'man page' information about how they are to be used, configured, and integrated into a larger stack.
files: /help.1 and /README.md
message: The 'helpfile' has to be provided.
reference_url: https://fedoraproject.org/wiki/Container:Guidelines#Help_File
tags: filesystem, helpfile and man
test: best_practices.py

/best_practices/no_root
class: NoRootCheck
description: It can be insecure to run service as root.
message: Service should not run as root by default.
reference_url: ?????
tags: root and user
test: best_practices.py

/dockerfile/from_tag_not_latest
class: FromTagNotLatestCheck
description: Using the 'latest' tag may cause unpredictable builds.It is recommended that a specific tag is used in the FROM.
message: In FROM, tag has to be specified and not 'latest'.
reference_url: https://fedoraproject.org/wiki/Container:Guidelines#FROM
tags: from, dockerfile, baseimage and latest
test: dockerfile.py

/dockerfile/maintainer_deprecated
class: MaintainerDeprecatedCheck
description: Replace with label 'maintainer'.
instruction: MAINTAINER
max_count: 0
message: Dockerfile instruction `MAINTAINER` is deprecated.
reference_url: https://docs.docker.com/engine/reference/builder/#maintainer-deprecated
tags: maintainer, dockerfile and deprecated
test: dockerfile.py

/labels/maintainer_label
class: MaintainerLabelCheck
description: The name and email of the maintainer (usually the submitter).
labels: maintainer
message: Label 'maintainer' has to be specified.
reference_url: https://fedoraproject.org/wiki/Container:Guidelines#LABELS
required: True
tags: maintainer and label
test: labels.py
value_regex: None

when I want to be supercool and have backward compilant output:

use format abilites of fmf:
fmf show --path colin/checks --format "{}\n -> {}\n -> {}\n -> {}\n -> {}\n\n" --value name --value "data['description']" --value "data['message']" --value "data['reference_url']" --value "data['tags']"

/best_practices/cmd_or_entrypoint
    -> An ENTRYPOINT allows you to configure a container that will run as an executable. The main purpose of a CMD is to provide defaults for an executing container.
    -> Cmd or Entrypoint has to be specified
    -> https://fedoraproject.org/wiki/Container:Guidelines#CMD.2FENTRYPOINT_2
    -> ['cmd', 'entrypoint']

/best_practices/help_file_or_readme
    -> Just like traditional packages, containers need some 'man page' information about how they are to be used, configured, and integrated into a larger stack.
    -> The 'helpfile' has to be provided.
    -> https://fedoraproject.org/wiki/Container:Guidelines#Help_File
    -> ['filesystem', 'helpfile', 'man']

/best_practices/no_root
    -> It can be insecure to run service as root.
    -> Service should not run as root by default.
    -> ?????
    -> ['root', 'user']

/dockerfile/from_tag_not_latest
    -> Using the 'latest' tag may cause unpredictable builds.It is recommended that a specific tag is used in the FROM.
    -> In FROM, tag has to be specified and not 'latest'.
    -> https://fedoraproject.org/wiki/Container:Guidelines#FROM
    -> ['from', 'dockerfile', 'baseimage', 'latest']

/dockerfile/maintainer_deprecated
    -> Replace with label 'maintainer'.
    -> Dockerfile instruction `MAINTAINER` is deprecated.
    -> https://docs.docker.com/engine/reference/builder/#maintainer-deprecated
    -> ['maintainer', 'dockerfile', 'deprecated']

/labels/maintainer_label
    -> The name and email of the maintainer (usually the submitter).
    -> Label 'maintainer' has to be specified.
    -> https://fedoraproject.org/wiki/Container:Guidelines#LABELS
    -> ['maintainer', 'label']

Nosetests output - direct

TARGET=tests/data/Dockerfile nosetests -d -v fmf_scheduler.py

test (fmf_scheduler.from_tag_not_latest) ... ok
test (fmf_scheduler.maintainer_deprecated) ... ok
test (fmf_scheduler.maintainer_label) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.003s

OK

using rulesets

RULESETPATH=rulesets/ TARGET=tests/data/Dockerfile nosetests -d -v fmf_scheduler.py
test (fmf_scheduler.check@from_tag_not_latest) ... ok
test (fmf_scheduler.check@maintainer_deprecated) ... ok
test (fmf_scheduler.check@maintainer_label) ... ok

advanced filtering

possible to apply them to rulesets or directy to testcases
FILTERS=tags:dockerfile TARGET=tests/data/Dockerfile nosetests -d -v fmf_scheduler.py

test (fmf_scheduler.from_tag_not_latest) ... ok
test (fmf_scheduler.maintainer_deprecated) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.001s

OK

$ NAMES="from_tag_not_latest;maintainer_label" TARGET=tests/data/Dockerfile nosetests -d -v fmf_scheduler.py

fmf_scheduler.py
test (fmf_scheduler.from_tag_not_latest) ... ok
test (fmf_scheduler.maintainer_label) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.002s

OK

rulesets filters

$ NAMES=default RULESETPATH=rulesets/ TARGET=tests/data/Dockerfile nosetests -d -v fmf_scheduler.py

test (fmf_scheduler.check@from_tag_not_latest) ... ok
test (fmf_scheduler.check@maintainer_deprecated) ... ok
test (fmf_scheduler.check@maintainer_label) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.003s

OK

$ NAMES=fedora RULESETPATH=rulesets/ TARGET=tests/data/Dockerfile nosetests -d -v fmf_scheduler.py
fedora ruleset is not given there, so that it runs 0 tests

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

TomasTomecek

It would be for the best to discuss this in person.

TomasTomecek · 2018-06-01T07:45:04Z

colin/checks/dockerfile.py.fmf

@@ -0,0 +1,19 @@
+description: "asdasdsfdasfsda f"


what format is this? is it yaml?

TomasTomecek · 2018-06-01T07:48:01Z

colin/core/checks/abstract_check.py

+    def _get_fmf_metadata(self):
+        output = {}
+        classfile = inspect.getfile(self.__class__)
+        fmf_tree = fmf.Tree(os.path.dirname(classfile))


does this mean that we would have to store the metadata alongside the .py file?

TomasTomecek · 2018-06-01T07:48:56Z

colin/core/checks/abstract_check.py

+            setattr(self, k, metadata_dict[k])
+
+    def __init__(self, message=None, description=None, reference_url=None, tags=None):
+        if message or description or reference_url or tags:


better logic could be to load the metadata and just enable overriding them

TomasTomecek · 2018-07-16T13:55:24Z

fmf_scheduler.py

@@ -0,0 +1,188 @@
+#!/usr/bin/python3


Since this script actually proposes a new runtime, I would personally prefer to have it proposed in a different PR. I actually dislike that it's not integrated into colin's CLI interface.

yep, this is my suggested solution, split this PR, to 2 or 3 PRs, and last of them will be this nosetests generator.

But on other hand, without this, it is harder to show benefits eg:

write tests just in metadata without empty python classes

using nosetests scheduled tests

filtering and selecting or test items

using FMF rulesets

And this PR will just split metadata outside python classes to FMF files.
But I agree and with this knowledge, that these PRs are closely connected I can split it.

TomasTomecek · 2018-07-16T13:58:21Z

colin/checks/dockerfile.py

-                      reference_url="https://fedoraproject.org/wiki/Container:Guidelines#FROM",
-                      tags=["from", "dockerfile", "baseimage", "latest"])
+class FromTagNotLatestCheck(FMFAbstractCheck, DockerfileAbstractCheck):
+    name, metadata = FMFAbstractCheck.get_metadata("from_tag_not_latest")


I wonder whether there is a nicer way of doing this. Calling functions on class' attributes outside of methods seems sketchy.

Yep, I had also troubles with this, but actually there is probably not better way how to do it without bigger changes in colin. Because current colin implementation does static inspection of classes, to find checks based on class attribute name. If you have some idea I'll be happy to change it to better way

jscotka · 2018-07-17T08:57:07Z

This PR can be closed, PR splitted to more PRs:
#159
#160
#161

jscotka force-pushed the fmf_metadata branch 2 times, most recently from a5c8249 to f8c4ef7 Compare May 31, 2018 14:27

user-cont deleted a comment May 31, 2018

TomasTomecek requested changes Jun 1, 2018

View reviewed changes

jscotka force-pushed the fmf_metadata branch from e0f36d7 to f8afd61 Compare June 1, 2018 16:18

user-cont deleted a comment Jun 1, 2018

user-cont deleted a comment from TomasTomecek Jun 1, 2018

user-cont deleted a comment Jun 1, 2018

jscotka force-pushed the fmf_metadata branch 2 times, most recently from af8f0e9 to caf053c Compare June 4, 2018 08:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FMF metadata support to colin#141

FMF metadata support to colin#141
jscotka wants to merge 15 commits intouser-cont:masterfrom
jscotka:fmf_metadata

jscotka commented May 31, 2018 •

edited

Loading

Uh oh!

TomasTomecek left a comment

Uh oh!

TomasTomecek Jun 1, 2018

Uh oh!

TomasTomecek Jun 1, 2018

Uh oh!

TomasTomecek Jun 1, 2018

Uh oh!

TomasTomecek Jul 16, 2018

Uh oh!

jscotka Jul 17, 2018

Uh oh!

TomasTomecek Jul 16, 2018

Uh oh!

jscotka Jul 17, 2018

Uh oh!

jscotka commented Jul 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jscotka commented May 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

FMF Metadata works well

TODOs:

Colin output:

FMF output

when I want to be supercool and have backward compilant output:

Nosetests output - direct

using rulesets

advanced filtering

rulesets filters

Uh oh!

TomasTomecek left a comment

Choose a reason for hiding this comment

Uh oh!

TomasTomecek Jun 1, 2018

Choose a reason for hiding this comment

Uh oh!

TomasTomecek Jun 1, 2018

Choose a reason for hiding this comment

Uh oh!

TomasTomecek Jun 1, 2018

Choose a reason for hiding this comment

Uh oh!

TomasTomecek Jul 16, 2018

Choose a reason for hiding this comment

Uh oh!

jscotka Jul 17, 2018

Choose a reason for hiding this comment

Uh oh!

TomasTomecek Jul 16, 2018

Choose a reason for hiding this comment

Uh oh!

jscotka Jul 17, 2018

Choose a reason for hiding this comment

Uh oh!

jscotka commented Jul 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jscotka commented May 31, 2018 •

edited

Loading