Add Azure Container Registry support #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes - updates to README.md - some test streamlining - updated testify/assert test dependency to latest release
|
@stevesloka @oliverspryn @singram please let me know if there is anything I can do to help getting this PR approved. The ultimate goal is to have Azure Container Registry support in minikube. |
stevesloka
requested changes
Jan 15, 2020
There was a problem hiding this comment.
Overall it LGTM, however, I don't have a good way to test as I don't use Azure for things. If you feel good about it, @karolz-ms we can merge with your support.
One small nit on the version change.
|
Thank you for quick reply @stevesloka , much appreciated. This will be tested and demoed by multiple people here at Microsoft and I am being paid to make it work. So if there are any problems with Azure, send them my way. Thanks again! |
|
Thank you for your contribution @karolz-ms. We appreciate your support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes
Hope this helps☺️