-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure Container Registry support #6483
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @karolz-ms! |
Hi @karolz-ms. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: karolz-ms The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #6483 +/- ##
=========================================
- Coverage 37.93% 37.83% -0.1%
=========================================
Files 128 128
Lines 8714 8737 +23
=========================================
Hits 3306 3306
- Misses 4982 5005 +23
Partials 426 426
|
(I should be recognized as CNCF contributor now) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (same as the others), thank you for adding Azure support!
/ok-to-test
Error: running mkcmp: exit status 1 |
You are very welcome! Thanks for taking care of this PR so quickly, much appreciated |
This PR adds Azure Container Registry support to minikube (registry-creds add-on).
The registry-creds component, including its public image, has been updated accordingly, see upmc-enterprises/registry-creds#82 for details.
Hope this helps!