Skip to content

Conversation

@diogotorres97
Copy link
Contributor

@diogotorres97 diogotorres97 commented Feb 22, 2022

We forgot to bump eslint-config-upload 😄

Related issue: #47

Without this bump, I got this on notification-service:

/Users/diogo.torres/Projects/uphold/notification-service/test/utils/nsq-message.js
  0:0  error  Parsing error: require() of ES Module /Users/diogo.torres/Projects/uphold/notification-service/node_modules/eslint-scope/lib/definition.js from /Users/diogo.torres/Projects/uphold/notification-service/node_modules/babel-eslint/lib/require-from-eslint.js not supported.
Instead change the require of definition.js in /Users/diogo.torres/Projects/uphold/notification-service/node_modules/babel-eslint/lib/require-from-eslint.js to a dynamic import() which is available in all CommonJS modules

@diogotorres97 diogotorres97 self-assigned this Feb 22, 2022
@diogotorres97 diogotorres97 marked this pull request as ready for review February 22, 2022 14:08
@satazor satazor merged commit 58d214c into master Feb 22, 2022
@satazor satazor deleted the support/bump-eslint-config-uphold branch February 22, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants