Bump eslint dependency to match eslint-config-uphold #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Americas @Finglas just an heads up. This commit should have resulted in a major version. Changing the lower range of a peer dependency should result in a major of the package that specifies it. |
satazor
changed the title
satazor
force-pushed
the
fix/peer-dep-eslint
branch
from
6d53653 to
bff0137
Compare
Latest version of eslint-config-uphold uses eslint@~8.7.0 but this packages used eslint@7 isntead.
satazor
force-pushed
the
fix/peer-dep-eslint
branch
from
bff0137 to
a58bc8b
Compare
Contributor
|
It just generates a warning, nothing breaks if you don't follow the version suggestion, so I wouldn't consider it a major version. |
Americas
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest version of eslint-config-uphold uses eslint@~8.7.0 but this packages used eslint@7 isntead.