ui/ performance optimization - #9
Merged
Merged
Conversation
added 2 commits
June 7, 2022 15:22
added 2 commits
June 8, 2022 10:17
| <PathListItem changeLogItem={change} showChangeType={type} /></div>) | ||
| } | ||
| {filteredChanges?.map((change: DataItem, index: number) => | ||
| <PathListItem key={index} changeLogItem={change} showChangeType={type} /> |
There was a problem hiding this comment.
it is not best practice to use index for react element key..
do we have maybe a key or some identifier for each dataItem that we can use instead?
Contributor
Author
There was a problem hiding this comment.
i know...but we dont have identifier.
should i inject it once the data injected?
| @@ -0,0 +1,24 @@ | |||
| import { useState, useEffect } from "react"; | |||
|
|
|||
| const useDebounce = (value, delay) => { | |||
There was a problem hiding this comment.
why can't we use lodash debounce or something else that already exists?
Contributor
Author
There was a problem hiding this comment.
its the solution i found to seperate the state update and the filter operation.
I as see it the trade off will be to hold another variable and make the debounce on him and useEffect to listen to that change to make the filter operation.
I come from the assumption, the state must be updated immediately
added 2 commits
June 8, 2022 16:18
lirazyehezkel
approved these changes
Jun 12, 2022
leon-up9
added a commit
that referenced
this pull request
Jun 12, 2022
* tooltip & width change (#7) Co-authored-by: Leon <> * Ui/group-changes-by-change-type (#8) map changes Co-authored-by: Leon <> * ui/ performance optimization (#9) * avoid unnecessery renderes * removed redundant code * added category change header * cleaned redeundant * pr comments * put color Co-authored-by: Leon <> * ui/ restore collapse button (#12) * avoid unnecessery renderes * removed redundant code * recover lost change type header * added category change header * cleaned redeundant * pr comments * put color * split accordions state to 2 atoms * atom rename * spaces removed * fix bad setState * reverst change * rel changed * pr comments Co-authored-by: Leon <> Co-authored-by: Gustavo Massaneiro <gustavomassa123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.