ui/ restore collapse button - #12
Merged
Merged
Conversation
added 14 commits
June 7, 2022 15:22
AmitFainholts
approved these changes
Jun 9, 2022
leon-up9
marked this pull request as ready for review
June 12, 2022 09:17
|
|
||
| useEffect(() => { | ||
| const isGloballyExtended = !accordions.find(x => x.id === JSON.stringify(changeLogItem))?.isCollapsed | ||
| setIsExpanded(isGloballyExtended) |
There was a problem hiding this comment.
keep the same word - you use expand and extend for the same meaning
Contributor
Author
we only want to collapse |
leon-up9
added a commit
that referenced
this pull request
Jun 12, 2022
* tooltip & width change (#7) Co-authored-by: Leon <> * Ui/group-changes-by-change-type (#8) map changes Co-authored-by: Leon <> * ui/ performance optimization (#9) * avoid unnecessery renderes * removed redundant code * added category change header * cleaned redeundant * pr comments * put color Co-authored-by: Leon <> * ui/ restore collapse button (#12) * avoid unnecessery renderes * removed redundant code * recover lost change type header * added category change header * cleaned redeundant * pr comments * put color * split accordions state to 2 atoms * atom rename * spaces removed * fix bad setState * reverst change * rel changed * pr comments Co-authored-by: Leon <> Co-authored-by: Gustavo Massaneiro <gustavomassa123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.