Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add action to check project changes and provide feedback on each PR #1693

Merged
merged 13 commits into from
Nov 14, 2019
Merged

add action to check project changes and provide feedback on each PR #1693

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
22d288b
scaffolding the action to run for each PR
shiftkey Nov 11, 2019
9094126
appease the rubocop deities
shiftkey Nov 11, 2019
13e76ef
fleshing out the missing pieces
shiftkey Nov 11, 2019
94785ab
maybe we'll get this working?
shiftkey Nov 11, 2019
0dcfa80
use the payload to get the correct number of files in this PR
shiftkey Nov 12, 2019
29b8b38
rubocop
shiftkey Nov 12, 2019
2b1b352
can we query for PR comments?
shiftkey Nov 12, 2019
b2d42e7
do we have a valid query?
shiftkey Nov 12, 2019
3b0cf43
refactor it all omg
shiftkey Nov 12, 2019
7274866
ensure we use the custom token when interacting with the GitHub API
shiftkey Nov 14, 2019
fa3554c
some tidy up
shiftkey Nov 14, 2019
9352d6e
no need to do this any more
shiftkey Nov 14, 2019
bd65fd5
ensure we're running in our expected directory
shiftkey Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rubocop
  • Loading branch information
@shiftkey
shiftkey committed Nov 14, 2019
commit 29b8b3814fb6e8491027f2fa4d5c9146f1a2fc9c
2 changes: 1 addition & 1 deletion .github/actions/project-analyzer/project_analyzer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
exit 0
end

files = raw_files.map { |f| f.chomp }
files = raw_files.map(&:chomp)

def repository_check(project)
result = GitHubRepositoryActiveCheck.run(project)
Expand Down