Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add action to check project changes and provide feedback on each PR #1693

Merged
merged 13 commits into from
Nov 14, 2019

Conversation

shiftkey
Copy link
Member

This PR adds an action that runs on every pull_request event and does a few things:

  • check the PR adds or modifies any files under _data/projects
  • parses the files and checks they are valid
  • for GitHub projects, run additional checks that
    • the repository exists and is valid
    • the label specified is in use
    • the label and link are in sync when the project links directly to the label

This is codifying several checks that I've been manually doing up until now, and it'd be great to not have to do this to save time. Ideally this comment will help contributors fix things without needing to dig into the Actions logs to see why something failed...

@shiftkey
Copy link
Member Author

I've been poking at this locally with some contrived scenarios, but I'm going to merge this in next and see if I can run it against some open PRs and get some real-world testing out of it.

@shiftkey shiftkey merged commit f1e0544 into up-for-grabs:gh-pages Nov 14, 2019
@shiftkey shiftkey deleted the project-analyzer branch November 14, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant