-
Couldn't load subscription status.
- Fork 11
fix: ensure no crash if emhttp state configs are missing #1514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update introduces directory-safe file writing utilities, applies them in store synchronization, and adjusts error handling during module initialization. It also reorganizes GraphQL schema type placements, updates a configuration file's version and formatting, and adds a Justfile for development automation in the shared package. Changes
Sequence Diagram(s)sequenceDiagram
participant StoreSync
participant FileUtil
StoreSync->>FileUtil: ensureWriteSync(path, data)
FileUtil->>FileUtil: mkdir -p (parent directories)
FileUtil->>FileUtil: writeFileSync(path, data)
FileUtil-->>StoreSync: (operation complete)
sequenceDiagram
participant ConnectionService
participant Logger
ConnectionService->>ConnectionService: Check config keys
alt Any keys missing
ConnectionService->>Logger: Log warning with missing keys
end
ConnectionService->>ConnectionService: Continue initialization
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (5)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
d69d628 to
7ab903d
Compare
|
This plugin has been deployed to Cloudflare R2 and is available for testing. |
🤖 I have created a release *beep* *boop* --- ## [4.10.0](v4.9.5...v4.10.0) (2025-07-15) ### Features * trial extension allowed within 5 days of expiration ([#1490](#1490)) ([f34a33b](f34a33b)) ### Bug Fixes * delay `nginx:reload` file mod effect by 10 seconds ([#1512](#1512)) ([af33e99](af33e99)) * **deps:** update all non-major dependencies ([#1489](#1489)) ([53b05eb](53b05eb)) * ensure no crash if emhttp state configs are missing ([#1514](#1514)) ([1a7d35d](1a7d35d)) * **my.servers:** improve DNS resolution robustness for backup server ([#1518](#1518)) ([eecd9b1](eecd9b1)) * over-eager cloud query from web components ([#1506](#1506)) ([074370c](074370c)) * replace myservers.cfg reads in UpdateFlashBackup.php ([#1517](#1517)) ([441e180](441e180)) * rm short-circuit in `rc.unraid-api` if plugin config dir is absent ([#1515](#1515)) ([29dcb7d](29dcb7d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Summary by CodeRabbit
New Features
Bug Fixes
Chores