Skip to content

fix: over-eager cloud query from web components #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

fix: over-eager cloud query from web components #1506

merged 1 commit into from
Jul 11, 2025

Conversation

@pujitm
Copy link
Member

@pujitm pujitm commented Jul 11, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Improved initialization logic to ensure cloud state is only loaded when the connect plugin is installed, enhancing reliability during startup.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 11, 2025 •
edited
Loading

Walkthrough

The delayed initialization logic in the server store was updated so that loadCloudState() is now only called if the connectPluginInstalled.value is truthy, while load() continues to be called unconditionally. No changes were made to exported or public entity declarations.

Changes

File(s) Change Summary
web/store/server.ts Added a conditional check: loadCloudState() runs only if connectPluginInstalled.value is true.

Poem

When plugins connect, the cloud may awake,
But if not installed, no extra call to make.
The server still loads, as it always should,
Guarded by logic, as only code could.
A simple check, a subtle shift—
In the world of stores, a thoughtful lift!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d8d6b4 and ca19d45.

📒 Files selected for processing (1)
  • web/store/server.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/store/server.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build Web App
  • GitHub Check: Test API
  • GitHub Check: Build API
  • GitHub Check: Analyze (javascript-typescript)
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pujitm pujitm force-pushed the fix/7.2-connect-init branch from 7d8d6b4 to ca19d45 Compare July 11, 2025 17:59
@github-actions
Copy link
Contributor

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1506/dynamix.unraid.net.plg

@pujitm pujitm marked this pull request as ready for review July 11, 2025 18:10
@elibosley elibosley merged commit 074370c into main Jul 11, 2025
11 checks passed
@elibosley elibosley deleted the fix/7.2-connect-init branch July 11, 2025 18:16
@github-actions github-actions bot mentioned this pull request Jul 11, 2025
Merged
elibosley pushed a commit that referenced this pull request Jul 15, 2025
@github-actions
chore(main): release 4.10.0 (#1505)
81808ad 
🤖 I have created a release *beep* *boop*
---


## [4.10.0](v4.9.5...v4.10.0)
(2025-07-15)


### Features

* trial extension allowed within 5 days of expiration
([#1490](#1490))
([f34a33b](f34a33b))


### Bug Fixes

* delay `nginx:reload` file mod effect by 10 seconds
([#1512](#1512))
([af33e99](af33e99))
* **deps:** update all non-major dependencies
([#1489](#1489))
([53b05eb](53b05eb))
* ensure no crash if emhttp state configs are missing
([#1514](#1514))
([1a7d35d](1a7d35d))
* **my.servers:** improve DNS resolution robustness for backup server
([#1518](#1518))
([eecd9b1](eecd9b1))
* over-eager cloud query from web components
([#1506](#1506))
([074370c](074370c))
* replace myservers.cfg reads in UpdateFlashBackup.php
([#1517](#1517))
([441e180](441e180))
* rm short-circuit in `rc.unraid-api` if plugin config dir is absent
([#1515](#1515))
([29dcb7d](29dcb7d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Oct 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elibosley elibosley elibosley approved these changes

@mdatelle mdatelle Awaiting requested review from mdatelle

@zackspear zackspear Awaiting requested review from zackspear

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pujitm @elibosley