-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Match FrameworkElement.[Measure|Arrange]Override with Windows #13839
Conversation
c528346
to
ab9dcb8
Compare
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
ab9dcb8
to
74fd140
Compare
@jeromelaban Is this good to merge? |
I don't know yet if it is, this is a significant change that needs screenshot validations. Did you check those as well? There are also impacts on native controls, which may not be tested automatically. |
Yup I checked screenshot comparison a while ago when I have opened the PR. Nothing was looking interesting there. Note that a behavior change here can only happen for classes that inherit from |
Ok, let's merge as-is, though we'll need to validate the behavior a bit more with the deployed samples app. |
Yup sure! |
GitHub Issue (If applicable): closes #1554
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Copilot Summary
🤖 Generated by Copilot at 2b75eac
This pull request refactors the layout logic for
FrameworkElement
and its subclasses by introducing helper methods to measure and arrange the first child element, and by returning the default size in the baseFrameworkElement
methods. This simplifies the code and improves the consistency with the WinUI behavior. The pull request also adds the necessary assembly attributes and using directives to support the media player implementations.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):