Skip to content

Conversation

@Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented May 14, 2025

GitHub Issue (If applicable): closes #1309, closes #1310, closes #1391

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

What is the new behavior?

CommandExtensions.Command now support ToggleSwitch which triggers on Toggled.

PR Checklist

Please check if your PR fulfills the following requirements:

@unodevops
Copy link
Contributor

⚠️⚠️ The build 165608 has failed on Uno Toolkit - CI.

@Xiaoy312
Copy link
Contributor Author

useless default readme removed due to:

samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples/ReadMe.md:7:136 MD047/single-trailing-newline Files should end with a single newline character

@Xiaoy312 Xiaoy312 merged commit 5c11fc1 into main May 16, 2025
21 checks passed
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20250514/toggle-switch-command branch May 16, 2025 16:39
@DevTKSS
Copy link

DevTKSS commented Jun 19, 2025

@Xiaoy312 can you tell, how this now would be expected to be used? I would then add / exchange the appropriate call I used to add on this unoplatform/uno.extensions#2749 PR to the ThemeService. How would be able to use the toggle switch for this?

@kazo0
Copy link
Contributor

kazo0 commented Jun 19, 2025

@DevTKSS The docs should be updated to show an example usage here: https://github.com/unoplatform/uno.toolkit.ui/blob/31711a1e1d730cf3d3d91269c58d6e0a6d1c63d7/doc/helpers/command-extensions.md#usage

I see it hasn't been published to the main docs yet so I will look into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants