Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass auth to custom registry #77

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Conversation

cpreston321
Copy link
Member

@cpreston321 cpreston321 commented Jan 22, 2023

Resolves: #78

This change will inherit auth to custom GET registry -- just in case it is a private repo that I want to access. I want to use this soon as possible!

If you have any questions please let me know thanks! I will try to make changes if you have any better suggestions 💚

@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Merging #77 (7fbad97) into main (d1d539c) will decrease coverage by 0.32%.
The diff coverage is 64.28%.

❗ Current head 7fbad97 differs from pull request most recent head 1413835. Consider uploading reports for the commit 1413835 to get more accurate results

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   70.00%   69.68%   -0.32%     
==========================================
  Files           6        6              
  Lines         310      320      +10     
  Branches       41       44       +3     
==========================================
+ Hits          217      223       +6     
- Misses         93       97       +4     
Impacted Files Coverage Δ
src/registry.ts 35.71% <28.57%> (-3.42%) ⬇️
src/giget.ts 81.66% <100.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cpreston321 cpreston321 changed the title feat: add auth to custom registry fix: add auth to custom registry Jan 22, 2023
src/giget.ts Outdated Show resolved Hide resolved
@cpreston321 cpreston321 requested a review from pi0 January 23, 2023 14:30
@pi0 pi0 changed the title fix: add auth to custom registry fix: pass auth to custom registry Feb 16, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 28ef2ef into unjs:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom registry provider can't access private Github repo.
2 participants