Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downloadTemplate broken since last update #81

Closed
Princesseuh opened this issue Feb 17, 2023 · 2 comments · Fixed by #82
Closed

downloadTemplate broken since last update #81

Princesseuh opened this issue Feb 17, 2023 · 2 comments · Fixed by #82

Comments

@Princesseuh
Copy link

Princesseuh commented Feb 17, 2023 •
edited
Loading

Environment

Node v16.19.0, pnpm, macOS

Reproduction

Your own CI

Describe the bug

Since the latest update (1.1.0), downloadTemplate returns a 400 on Node 16 while hitting GitHub. This happens in giget CI, but is also breaking people downstream, including create-astro.

image

The original PR (#77) also had this test fail.

Additional context

No response

Logs

Failed to download https://github.com/unjs/template/archive/main.tar.gz: 400 Bad Request
This was referenced Feb 17, 2023
Closed
Merged
@pi0 pi0 mentioned this issue Feb 17, 2023
Merged
@pi0 pi0 closed this as completed in #82 Feb 17, 2023
@pi0
Copy link
Member

pi0 commented Feb 17, 2023

Should be fixed in latest release.

@Princesseuh
Copy link
Author

Thank you for the quick fix!

@natemoo-re natemoo-re mentioned this issue Aug 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: normalize fetch headers unjs/giget
2 participants
@Princesseuh @pi0