Skip to content

Reverse changes made by mistake with the wrong commit#37

Merged
ENikS merged 1 commit intounitycontainer:developfrom
hypercodeplace:pipeline-manager-cache
Apr 15, 2020
Merged

Reverse changes made by mistake with the wrong commit#37
ENikS merged 1 commit intounitycontainer:developfrom
hypercodeplace:pipeline-manager-cache

Conversation

@hypercodeplace
Copy link

Reverse changes made by mistake with the wrong commit. Part 1.
Discussion is here: #29

After this PR is merged, it is needed to merge the next PR: #36

@dnfclas
Copy link

dnfclas commented Apr 15, 2020

CLA assistant check
All CLA requirements met.

@ENikS ENikS merged commit ae1291a into unitycontainer:develop Apr 15, 2020
@ENikS
Copy link
Contributor

ENikS commented Apr 15, 2020

Calling method.GetBaseDefinition() twice (worst case) will degrade performance. I can not agree to this approach. What exactly are you trying to fix here?

If this was in original pr, I must have optimized it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants