Skip to content

Issues 28: Cache base method definition in pipeline manager.#29

Merged
ENikS merged 1 commit intounitycontainer:masterfrom
hypercodeplace:cache-base-definition
Apr 24, 2019
Merged

Issues 28: Cache base method definition in pipeline manager.#29
ENikS merged 1 commit intounitycontainer:masterfrom
hypercodeplace:cache-base-definition

Conversation

@hypercodeplace
Copy link

Description and discussion of the task is here: #28

@ENikS ENikS added this to the 5.10.1 milestone Apr 23, 2019
@ENikS ENikS merged commit 44c5519 into unitycontainer:master Apr 24, 2019
@hypercodeplace
Copy link
Author

Hey @ENikS , I notices that you have erased my commit f0f1a10 and now it appears in the repository as your commit b38bce2.
I just want to find out how it happened? I think it's not good to hide contributors of open source repositories.

@ENikS
Copy link
Contributor

ENikS commented Apr 14, 2020

I have nothing to do with it, I don't have these powers. You might ask GitHub admins why the repo is unknown. Did you delete your repository or profile?

@hypercodeplace
Copy link
Author

why the repo is unknown

This is not a question about unknown repository repository, but about git history.

Did you delete your repository or profile?

I deleted the fork as unnecessary, I have never deleted my profile.

You might ask GitHub admins

@ENikS I think this is not a question of the GitHub administrators, but the fact that you, probably, did a force push or squash merge?

@ENikS
Copy link
Contributor

ENikS commented Apr 14, 2020

I did a lot of refactoring lately and planing to do more in near feature. If your changes got squashed, it was not intentional but I am sorry nonetheless.

Generally, I'd like to expand contributors list, not shrink it, so if you feel so inclined, you are welcome to resubmit and I would be more than happy to add these to the history.

@hypercodeplace
Copy link
Author

@ENikS Thanks for your answer.

I understand that most likely this happened unintentionally. If you do not mind, I would like to restore the history.

you are welcome to resubmit

Could you please explain what do you mean by "resubmit"?

@ENikS
Copy link
Contributor

ENikS commented Apr 14, 2020 via email

@hypercodeplace
Copy link
Author

But if all changes are already in master, there will be no any changes in another PR?

@ENikS
Copy link
Contributor

ENikS commented Apr 14, 2020 via email

@hypercodeplace
Copy link
Author

@ENikS Ok, thank you, Eugene, will do something.
And I wish you a speedy recovery! 💪🤜🦠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants