This repository was archived by the owner on Jul 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
Add preventDefault for global Finder shortcuts #146
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
/* | ||
* Firefox has binds for Ctrl+k, Cmd+k, and "/" We want to use those to open | ||
* the Finder. | ||
* | ||
* Unfortunately we can't do this in Elm, since Browser.Events doesn't support | ||
* preventDefault, so we're duplicating the shortcuts and calling | ||
* preventDefault in JS. The Elm handler picks up the event later on. | ||
* | ||
* TODO: This is a bit brittle and relies on the Elm handler being added after | ||
* this one. There might be a better solution build with ports for this. | ||
*/ | ||
|
||
function preventDefaultGlobalKeyboardEvents() { | ||
window.addEventListener("keydown", (ev) => { | ||
if ( | ||
ev.key === "/" || | ||
(ev.metaKey && ev.key == "k") || | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
(ev.ctrlKey && ev.key == "k") | ||
) { | ||
ev.preventDefault(); | ||
} | ||
}); | ||
} | ||
|
||
export default preventDefaultGlobalKeyboardEvents; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated removal of comment that wasn't relevant anymore.