This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Add preventDefault for global Finder shortcuts #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox has some clashes with the keyboard shortcuts of the Finder that can't be prevented from within Elm; add a simple— slightly hackish— event handler on the JavaScript side to preventDefault on the specific Finder keyboard events.
hojberg
commented
Jun 8, 2021
| @@ -86,7 +86,6 @@ update env msg model = | |||
| |> RemoteData.withDefault False | |||
|
|
|||
| newModel = | |||
| -- TODO: Update to Loading | |||
There was a problem hiding this comment.
Unrelated removal of comment that wasn't relevant anymore.
hojberg
commented
Jun 8, 2021
| window.addEventListener("keydown", (ev) => { | ||
| if ( | ||
| ev.key === "/" || | ||
| (ev.metaKey && ev.key == "k") || |
pchiusano
approved these changes
Jun 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Firefox has some clashes with the keyboard shortcuts of the Finder that
can't be prevented from within Elm (elm/browser#89); add a simple— slightly hackish—
event handler on the JavaScript side to preventDefault on the specific
Finder keyboard events.
Fixes: #136