Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DryDataProvider #5141

Merged
merged 8 commits into from
Jul 4, 2024
Merged

DryDataProvider #5141

merged 8 commits into from
Jul 4, 2024

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Jun 27, 2024 •
edited by sffc
Loading

#58

@robertbastian robertbastian requested review from sffc, Manishearth and a team as code owners June 27, 2024 15:12
@sffc

This comment was marked as off-topic.

Sign in to view
@sffc sffc added the discuss-priority Discuss at the next ICU4X meeting label Jun 27, 2024
@robertbastian robertbastian marked this pull request as draft June 28, 2024 08:49
@robertbastian robertbastian marked this pull request as ready for review June 28, 2024 10:13
@robertbastian robertbastian changed the title CanLoad data provider DryDataProvider Jul 1, 2024
@robertbastian robertbastian requested a review from sffc July 1, 2024 09:07
sffc
sffc requested changes Jul 1, 2024
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the name DryDataProvider

provider/adapters/src/fallback/mod.rs Outdated Show resolved Hide resolved
provider/adapters/src/filter/mod.rs Show resolved Hide resolved
provider/core/src/buf/serde.rs Outdated Show resolved Hide resolved
provider/core/src/data_provider.rs Outdated Show resolved Hide resolved
provider/fs/src/fs_data_provider.rs Show resolved Hide resolved
tools/ffi_coverage/src/allowlist.rs Outdated Show resolved Hide resolved
@robertbastian robertbastian requested a review from sffc July 2, 2024 08:19
@sffc sffc mentioned this pull request Jul 2, 2024
Open
sffc
sffc previously approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this and I noted the disagreement about the default impl in #58, which needs to be resolved before 2.0.

@robertbastian robertbastian removed the discuss-priority Discuss at the next ICU4X meeting label Jul 3, 2024
@robertbastian robertbastian requested a review from sffc July 3, 2024 17:11
@robertbastian robertbastian merged commit b3006b2 into unicode-org:main Jul 4, 2024
28 checks passed
@robertbastian robertbastian deleted the canload branch July 4, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 left review comments

@sffc sffc sffc approved these changes

@Manishearth Manishearth Awaiting requested review from Manishearth Manishearth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertbastian @sffc @jedel1043