comments

unicode-org · Jul 3, 2024 · 5233846 · 5233846
1 parent 62dcaea
commit 5233846
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/provider/core/src/data_provider.rs b/provider/core/src/data_provider.rs
@@ -84,9 +84,7 @@ pub trait DryDataProvider<M: DataMarker>: DataProvider<M> {
     /// that `dry_load` cannot predict.
     ///
     /// [`load`]: DataProvider::load
-    fn dry_load(&self, req: DataRequest) -> Result<DataResponseMetadata, DataError> {
-        self.load(req).map(|r| r.metadata)
-    }
+    fn dry_load(&self, req: DataRequest) -> Result<DataResponseMetadata, DataError>;
 }
 
 /// A data provider that loads data for a specific data type.
@@ -124,9 +122,7 @@ pub trait DynamicDryDataProvider<M: DynamicDataMarker>: DynamicDataProvider<M> {
         &self,
         marker: DataMarkerInfo,
         req: DataRequest,
-    ) -> Result<DataResponseMetadata, DataError> {
-        self.load_data(marker, req).map(|r| r.metadata)
-    }
+    ) -> Result<DataResponseMetadata, DataError>;
 }
 
 impl<'a, M, P> DynamicDataProvider<M> for &'a P

diff --git a/tools/ffi_coverage/src/allowlist.rs b/tools/ffi_coverage/src/allowlist.rs
@@ -68,19 +68,19 @@ lazy_static::lazy_static! {
         "AsDynamicDataProviderAnyMarkerWrap",
         "IterableDynamicDataProvider",
         "IterableDataProvider",
-        "DataConverter",
-        "Filterable",
         "ForkByErrorPredicate",
 
         // The main data provider traits should be covered if the enum or struct
         // implementing them is covered
         "DataProvider",
         "DynamicDataProvider",
-        "DryDataProvider",
-        "DynamicDryDataProvider",
         "BufferProvider",
         "AnyProvider",
 
+        // We might expose these if someone asks for it
+        "DryDataProvider",
+        "DynamicDryDataProvider",
+
         // internal trait, all methods replicated on Date
         "Calendar",
         // Rust-specific conversion trait