-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-16239 reduce lateral inher., harden some values to ensure same when resolved #2734
Conversation
…hen resolved -New -fW for CLDRModify hardens values based on output of CompareResolved -Minor revision of CompareResolved for lines to start with ≠DIFF and locale -Resulting xml
the goal here is not actually to change any code or data, but to check whether there are any problematic discrepancies between this data and the data that resulted from #2722 as we discussed, there's more than one way to "harden" the xml while ensuring the fully-resolved values remain the same; this alternative way is for comparison the way I ran CLDRModify and CompareResolved is very complicated; following are the actual steps
|
first impression is that these changes indicate a smaller amount of "hardening" in my method than in Mark's method in some cases however it's the other way around; some sub-locales get a few "hardened" units such as "length-nautical-mile" |
Test error: "Error: (TestBasic.java:757) Error: Default content file not empty: nn_NO" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in all the many cases i spot checked, this replaces real values with inheritance marker. Is that the opposite of what this says it does?
I think this is working from the original source, before the hardening that my PR applied. So it would be 'restoring' the values. I scanned it over, and I think there are some valuable learnings. What I think we should do is go forward with what is in main, but for v44 look at reprocessing the source to add some inheritance markers. Namely,
Let's file a ticket to consider it. |
"I think this is working from the original source, before the hardening that my PR applied. So it would be 'restoring' the values." -- yes, that's my understanding as well -- in other words, these are cases where Mark's method hardened the value and my method didn't -- again, though, that's not a very important difference as long as the resulting resolved values are the same |
"valuable learnings ... for v44 ... file a ticket" -- good! |
New v44 ticket is https://unicode-org.atlassian.net/browse/CLDR-16414 |
-New -fW for CLDRModify hardens values based on output of CompareResolved
-Minor revision of CompareResolved for lines to start with ≠DIFF and locale
-Resulting xml
CLDR-16239
ALLOW_MANY_COMMITS=true