Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16239 Revised data with hardened values #2722

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented Feb 16, 2023

CLDR-16239

  1. Generated revised data using the CLDRModify -fV option from CLDR-16239 fix main lateral inheritance #2715. This replaces lateral inheritance when necessary. Almost all of these change the inheritance marker to the equivalent bailey value. < 100 of them changed missing values (getStringValue() == null) to the equivalent bailey value.
  2. Verified the result with CompareResolved, to make sure that the resolved results from the old main and the generated main are identical.
  3. Then copied the results into main to create this PR. Note that many of the file changes are "empty", just a copyright change.
  4. Had to make changes in c727a5f to fix logical group errors in bs.xml and bs_Cyrl.xml. It appears that the logical group check doesn't some but not all items to have inheritanceMarker, so fixed that (and filed ticket).

See also email.

Note that a bunch of the changes are just copyright updates, which would happen later anyway.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@macchiati
Copy link
Member Author

PS. This isn't final because of ka.xml, but I can get that later, after #2715 is merged.

@macchiati macchiati force-pushed the CLDR-16239-Revised-data-with-hardened-values branch from f5209b6 to c727a5f Compare February 16, 2023 16:27
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spot check looks OK. Would be good if copyright-year-only were omitted.

@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" ?>
<!DOCTYPE ldml SYSTEM "../../common/dtd/ldml.dtd">
<!-- Copyright © 1991-2022 Unicode, Inc.
<!-- Copyright © 1991-2023 Unicode, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd been not checking in these copyright-only changes. Would be good to skip these, regardless of how CLDR-14239 shakes out.

@@ -4496,6 +4496,30 @@ CLDR data files are interpreted according to the LDML specification (http://unic
<compoundUnit type="times">
<compoundUnitPattern>↑↑↑</compoundUnitPattern>
</compoundUnit>
<unit type="angle-revolution">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a ^^^ but it is a missing (aka null)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants