Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page hero component should use an optional CTA #997

Closed
theadamparker opened this issue Jul 19, 2022 · 10 comments · Fixed by #1130
Closed

Page hero component should use an optional CTA #997

theadamparker opened this issue Jul 19, 2022 · 10 comments · Fixed by #1130
Assignees
@Jura @paboden @mrelevo
Labels
enhancement New feature or request extdev outsourcing to external vendor

Comments

@theadamparker
Copy link
Contributor

No description provided.

@theadamparker theadamparker added enhancement New feature or request design This issue requires design work before development can begin labels Jul 19, 2022
@theadamparker theadamparker self-assigned this Jul 19, 2022
@Jura
Copy link
Member

Jura commented Jul 19, 2022

Do you think we should implement it in the Storybook? Those are elements which are sufficiently represented throughout the site, specific implementation when we are including CTA to the Hero is our Site Studio matter, same way as we can enrich it with modal window if necessary. Or incorporate buttons. i don't think it is required to be in Storybook.

@theadamparker
Copy link
Contributor Author

@Jura it's a treatment we can officially endorse by including it in Figma and Storybook. A small enhancement to the component that takes the guesswork out of creating it, and ensures a consistent treatment with the homepage hero.

@Jura
Copy link
Member

Jura commented Jul 19, 2022

Ok, no problem

@theadamparker
Copy link
Contributor Author

CTA has been added to the "Page hero" component in Figma.
Screen Shot 2022-07-20 at 3 28 45 PM

@theadamparker theadamparker removed the design This issue requires design work before development can begin label Jul 20, 2022
@theadamparker theadamparker assigned Jura and unassigned theadamparker Jul 20, 2022
@theadamparker theadamparker mentioned this issue Jul 26, 2022
Closed
@Jura Jura added Conflicts Conflicts in the PR, cannot merge! extdev outsourcing to external vendor and removed Conflicts Conflicts in the PR, cannot merge! labels Oct 17, 2022
paboden added a commit that referenced this issue Feb 12, 2023
@paboden
Multiple updates to page hero
7976639 
#905 - Add option of page hero-full to allow for no background image

#997 - Allow for optional CTA link

#1008 - Added setup for optional overline and subtitle fields
@paboden paboden mentioned this issue Feb 12, 2023
Merged
@paboden paboden linked a pull request Feb 12, 2023 that will close this issue
Multiple updates to page hero #1130
Merged
@Jura
Copy link
Member

Jura commented Feb 17, 2023

@paboden , CTA control should use properly formatted label, "CTA", instead of current "cta_enabled". it also should use On/Off notation for switcher instead of False/True
image

paboden added a commit that referenced this issue Feb 23, 2023
@paboden
#905 - #997 - #1008
5ae01f0 
Requested changes to control variable names for Overline, CTA, & Subtitle.
Moved text color classes to content parent container instead of on each content item.
Requested cleanup of code.
@paboden
Copy link
Contributor

paboden commented Feb 23, 2023

The PR for this issue is ready to review again. The storybook controls have been cleaned up.
#1130

@Jura
Copy link
Member

Jura commented Feb 27, 2023

Verified

@Jura Jura closed this as completed Feb 27, 2023
paboden added a commit that referenced this issue Mar 2, 2023
@paboden
#905 - #997 - #1008 -- Fix to page hero to make sure to use default i…
a3f7a81 
…mage variant.

Cleanup of related stories.
@paboden paboden mentioned this issue Mar 2, 2023
Merged
@Jura
Copy link
Member

Jura commented Mar 2, 2023

@mrelevo , please verify

@Jura Jura reopened this Mar 2, 2023
@mrelevo
Copy link
Contributor

mrelevo commented Mar 2, 2023

verified in Dev

Jura added a commit that referenced this issue Mar 7, 2023
@Jura
Merge pull request #1146 from undp/905-997-1008-multiple-updates-to-p…
3866dd1 
…age-hero

#905 - #997 - #1008 -- Fix to page hero to make sure to use default image variant
@mrelevo
Copy link
Contributor

mrelevo commented May 9, 2023

verified in storybook, already in Drupal

@mrelevo mrelevo closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jura Jura

@paboden paboden

@mrelevo mrelevo

Labels
enhancement New feature or request extdev outsourcing to external vendor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multiple updates to page hero undp/design-system
4 participants
@Jura @theadamparker @paboden @mrelevo