Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page hero should accept optional overline and subtitle fields #1008

Closed
theadamparker opened this issue Jul 26, 2022 · 7 comments · Fixed by #1130
Closed

Page hero should accept optional overline and subtitle fields #1008

theadamparker opened this issue Jul 26, 2022 · 7 comments · Fixed by #1130
Assignees
@Jura @mrelevo
Labels
enhancement New feature or request extdev outsourcing to external vendor

Comments

@theadamparker
Copy link
Contributor

The page hero requires a "title" but should also accept either an "overline" (above the title) or a "subtitle" (beneath the title). Mockups are available in Figma in "Page hero."
@theadamparker theadamparker added the enhancement New feature or request label Jul 26, 2022
@theadamparker
Copy link
Contributor Author

This issue is closely related to #997 and #905

@Jura Jura added Conflicts Conflicts in the PR, cannot merge! extdev outsourcing to external vendor and removed Conflicts Conflicts in the PR, cannot merge! labels Oct 17, 2022
paboden added a commit that referenced this issue Feb 12, 2023
@paboden
Multiple updates to page hero
7976639 
#905 - Add option of page hero-full to allow for no background image

#997 - Allow for optional CTA link

#1008 - Added setup for optional overline and subtitle fields
@paboden paboden mentioned this issue Feb 12, 2023
Merged
@paboden paboden linked a pull request Feb 12, 2023 that will close this issue
Multiple updates to page hero #1130
Merged
@Jura
Copy link
Member

Jura commented Feb 17, 2023

@paboden , Storybook controls should use properly formatted labels, "Overline" (not outline) and "Subtitle". It also should use On/Off notation for switcher instead of False/True
image

paboden added a commit that referenced this issue Feb 23, 2023
@paboden
#905 - #997 - #1008
5ae01f0 
Requested changes to control variable names for Overline, CTA, & Subtitle.
Moved text color classes to content parent container instead of on each content item.
Requested cleanup of code.
@paboden
Copy link
Contributor

paboden commented Feb 23, 2023

The PR for this issue is ready to review again. The storybook controls have been cleaned up.
#1130

@Jura
Copy link
Member

Jura commented Feb 27, 2023

verified

@Jura Jura closed this as completed Feb 27, 2023
paboden added a commit that referenced this issue Mar 2, 2023
@paboden
#905 - #997 - #1008 -- Fix to page hero to make sure to use default i…
a3f7a81 
…mage variant.

Cleanup of related stories.
@paboden paboden mentioned this issue Mar 2, 2023
Merged
@Jura
Copy link
Member

Jura commented Mar 2, 2023

@mrelevo , please verify

@Jura Jura reopened this Mar 2, 2023
@mrelevo
Copy link
Contributor

mrelevo commented Mar 2, 2023

verified in Dev

Jura added a commit that referenced this issue Mar 7, 2023
@Jura
Merge pull request #1146 from undp/905-997-1008-multiple-updates-to-p…
3866dd1 
…age-hero

#905 - #997 - #1008 -- Fix to page hero to make sure to use default image variant
@mrelevo
Copy link
Contributor

mrelevo commented May 9, 2023

verified in storybook already in Drupal

@mrelevo mrelevo closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jura Jura

@mrelevo mrelevo

Labels
enhancement New feature or request extdev outsourcing to external vendor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multiple updates to page hero undp/design-system
4 participants
@Jura @theadamparker @paboden @mrelevo