Skip to content

Conversation

louis820
Copy link

@louis820 louis820 commented Aug 6, 2025

This PR changes two things :

  • The Makefile now creates an unzipped version of the .wasm file
  • There is a new wrapping for parsing a cel rule without any input, which only checks the syntax of the rule

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2025

CLA assistant check
All committers have signed the CLA.

@matheusfm
Copy link
Contributor

Hi @louis820
Thanks a lot for the PR!

Just a couple of questions to better understand the changes:

  1. Is the cel-syntax wrapper intended to be used by the UI?
    From what I can see, it’s not being called.

  2. Any specific reason to version the uncompressed .wasm file?

Looking forward to your thoughts!

@louis820
Copy link
Author

Hi @matheusfm ,
Thank you for your review.

I use this code for a project where I needed to run CEL rules in JS.
That's why I store the .wasm.gz file, so that I can copy it to my project to be used. I probably should have included it in gitignore though my bad.
I have not added the logic to use the wrapper in the UI since I only needed the backend version for my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants