-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(all): Add reply to convo #154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
McPizza0
force-pushed
the
03-17-reply_to_messages_ui
branch
4 times, most recently
from
March 21, 2024 16:29
54c9a51
to
d08e439
Compare
McPizza0
force-pushed
the
03-17-reply_to_messages_ui
branch
2 times, most recently
from
March 22, 2024 17:16
9eca8c9
to
19e6a1c
Compare
McPizza0
force-pushed
the
03-17-reply_to_messages_ui
branch
from
March 23, 2024 22:19
19e6a1c
to
1fa212b
Compare
## What does this PR do? <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Fixes # (issue) _If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists_ <!-- If there isn't an issue for this PR, please re-review our Contributing Guide and create an issue --> ## Type of change <!-- Please mark the relevant points by using [x] --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Chore (refactoring code, technical debt, workflow improvements) - [ ] Enhancement (small improvements) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## Checklist <!-- We're starting to get more and more contributions. Please help us making this efficient for all of us and go through this checklist. Please tick off what you did --> ### Required - [ ] Read [Contributing Guide](https://github.com/un/inbox/blob/main/CONTRIBUTING.md) - [ ] Self-reviewed my own code - [ ] Tested my code in a local environment - [ ] Commented on my code in hard-to-understand areas - [ ] Checked for warnings, there are none - [ ] Removed all `console.logs` - [ ] Merged the latest changes from main onto my branch with `git pull origin main` - [ ] My changes don't cause any responsiveness issues ### Appreciated - [ ] If a UI change was made: Added a screen recording or screenshots to this PR - [ ] Updated the UnInbox Docs if changes were necessary
## What does this PR do? <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Fixes # (issue) _If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists_ <!-- If there isn't an issue for this PR, please re-review our Contributing Guide and create an issue --> ## Type of change <!-- Please mark the relevant points by using [x] --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Chore (refactoring code, technical debt, workflow improvements) - [ ] Enhancement (small improvements) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## Checklist <!-- We're starting to get more and more contributions. Please help us making this efficient for all of us and go through this checklist. Please tick off what you did --> ### Required - [ ] Read [Contributing Guide](https://github.com/un/inbox/blob/main/CONTRIBUTING.md) - [ ] Self-reviewed my own code - [ ] Tested my code in a local environment - [ ] Commented on my code in hard-to-understand areas - [ ] Checked for warnings, there are none - [ ] Removed all `console.logs` - [ ] Merged the latest changes from main onto my branch with `git pull origin main` - [ ] My changes don't cause any responsiveness issues ### Appreciated - [ ] If a UI change was made: Added a screen recording or screenshots to this PR - [ ] Updated the UnInbox Docs if changes were necessary
## What does this PR do? <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Fixes # (issue) _If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists_ <!-- If there isn't an issue for this PR, please re-review our Contributing Guide and create an issue --> ## Type of change <!-- Please mark the relevant points by using [x] --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Chore (refactoring code, technical debt, workflow improvements) - [ ] Enhancement (small improvements) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## Checklist <!-- We're starting to get more and more contributions. Please help us making this efficient for all of us and go through this checklist. Please tick off what you did --> ### Required - [ ] Read [Contributing Guide](https://github.com/un/inbox/blob/main/CONTRIBUTING.md) - [ ] Self-reviewed my own code - [ ] Tested my code in a local environment - [ ] Commented on my code in hard-to-understand areas - [ ] Checked for warnings, there are none - [ ] Removed all `console.logs` - [ ] Merged the latest changes from main onto my branch with `git pull origin main` - [ ] My changes don't cause any responsiveness issues ### Appreciated - [ ] If a UI change was made: Added a screen recording or screenshots to this PR - [ ] Updated the UnInbox Docs if changes were necessary
BlankParticle
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the UI and functionality to reply to incoming messages
with this we now have full inbound and outbound with replies in both directions