Skip to content

SFTP reads are supposed to be binary, so don't wrap with str() #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulope merged 1 commit into from
Sep 16, 2019
Merged

SFTP reads are supposed to be binary, so don't wrap with str() #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytest_sftpserver/sftp/interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def read(self, offset, length):
return SFTP_NO_SUCH_FILE

end = offset + length
return str(self.content_provider.get(self.path))[offset:end]
return self.content_provider.get(self.path)[offset:end]

def stat(self):
if self.content_provider.get(self.path) is None:
Expand Down
9 changes: 9 additions & 0 deletions tests/test_sftp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,15 @@ def test_sftpserver_put_file(content, sftpclient, tmpdir):
assert set(sftpclient.listdir("/a")) == set(["test.txt", "b", "c", "f"])


def test_sftpserver_round_trip(content, sftpclient, tmpdir):
tmpfile = tmpdir.join("test.txt")
thetext = u"Just some plain, normal text"
tmpfile.write(thetext)
sftpclient.put(str(tmpfile), "/a/test.txt")
with sftpclient.open("/a/test.txt", "r") as result:
assert result.read() == thetext.encode()


def test_sftpserver_remove_file_dict(content, sftpclient):
sftpclient.remove("/a/c")
assert set(sftpclient.listdir("/a")) == set(["b", "f"])
Expand Down